Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A572F431FAF for ; Fri, 30 Mar 2012 14:39:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G2NDuxFKQJc0 for ; Fri, 30 Mar 2012 14:39:07 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7D765431FAE for ; Fri, 30 Mar 2012 14:39:07 -0700 (PDT) Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.166.230.117] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SDjX8-0003ep-UN; Fri, 30 Mar 2012 18:39:03 -0300 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1SDjX3-0002ze-Da; Fri, 30 Mar 2012 18:38:53 -0300 From: David Bremner To: Stefano Zacchiroli , notmuch@notmuchmail.org Subject: Re: [PATCH v2]: contrib/notmuch-mutt In-Reply-To: <20120329133538.GA12117@upsilon.cc> References: <87iphszuv1.fsf@zancas.localnet> <20120329133538.GA12117@upsilon.cc> User-Agent: Notmuch/0.12+70~g46e73fe (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 30 Mar 2012 18:38:53 -0300 Message-ID: <878vihpy4y.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - Cc: 628018-quiet@bugs.debian.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2012 21:39:11 -0000 On Thu, 29 Mar 2012 15:35:38 +0200, Stefano Zacchiroli wrote: > > Here is an updated set of patches, which I consider final for inclusion > of notmuch-mutt as part of notmuch contrib/. AFAICT I've implemented > all changes that have been requested either on this list or in private > mail to me: renaming, Debian packaging, XDG userdir support, shell > quoting in all notmuch calls. TTBOMK, no further changes have been > requested. I tried out these patches, and they seem to work (to the limit of my mutt knowledge). I did notice a minor grammar issue in the DESCRIPTION of the man page, "capable of populating maildir" should be "a maildir" or "maildirs". In general for notmuch commit messages we expect a bit more of the rationale for the commit; in this case a few lines about the general purpose and (conceiveably) the implementation of notmuch-mutt would be welcome. See ebd1adc55b for a (probably overkill) example. d