Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 1DBC1431FBC
	for <notmuch@notmuchmail.org>; Sat, 29 Mar 2014 00:08:17 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id OhyvuLVgRXNd for <notmuch@notmuchmail.org>;
	Sat, 29 Mar 2014 00:08:09 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 6DC73431FAF
	for <notmuch@notmuchmail.org>; Sat, 29 Mar 2014 00:08:09 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 5EDD01000E5;
	Sat, 29 Mar 2014 09:08:03 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: push mark before signature on reply
In-Reply-To: <1396029865-23133-1-git-send-email-jani@nikula.org>
References: <1396029865-23133-1-git-send-email-jani@nikula.org>
User-Agent: Notmuch/0.17+159~gb806a13 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 29 Mar 2014 09:08:03 +0200
Message-ID: <m2vbux1nzg.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Mar 2014 07:08:17 -0000

On Fri, Mar 28 2014, Jani Nikula <jani@nikula.org> wrote:

> We push mark on reply so user can cut the quote. Push the mark before
> signature, if any, instead of end of buffer so the signature is
> preserved.
>
> This is consistent with message-kill-to-signature.
> ---

LGTM. +1

>  emacs/notmuch-mua.el | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index b16a10ecd379..ba3ef275ec5e 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -226,8 +226,12 @@ list."
>  	;; Quote the original message according to the user's configured style.
>  	(message-cite-original))))
>  
> -  (goto-char (point-max))
> +  ;; Push mark right before signature, if any.
> +  (message-goto-signature)
> +  (unless (eobp)
> +    (end-of-line -1))
>    (push-mark)
> +
>    (message-goto-body)
>    (set-buffer-modified-p nil))
>  
> -- 
> 1.9.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch