Return-Path: <amdragon@mit.edu>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 25165429E2F
	for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 20:00:45 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ogkegJWyjTMD for <notmuch@notmuchmail.org>;
	Wed, 11 Jan 2012 20:00:44 -0800 (PST)
Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU
	[18.9.25.15])
	by olra.theworths.org (Postfix) with ESMTP id AFD2A429E29
	for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 20:00:44 -0800 (PST)
X-AuditID: 1209190f-b7f8a6d000000914-0c-4f0e5aecb7dc
Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
	by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP
	id 3F.E4.02324.CEA5E0F4; Wed, 11 Jan 2012 23:00:44 -0500 (EST)
Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
	by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q0C40gCI007256; 
	Wed, 11 Jan 2012 23:00:42 -0500
Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
	(authenticated bits=0)
	(User authenticated as amdragon@ATHENA.MIT.EDU)
	by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0C40f0h015746
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
	Wed, 11 Jan 2012 23:00:42 -0500 (EST)
Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
	(envelope-from <amdragon@mit.edu>)
	id 1RlBqI-0004lS-HJ; Wed, 11 Jan 2012 23:00:46 -0500
Date: Wed, 11 Jan 2012 23:00:46 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding
	style
Message-ID: <20120112040046.GX20796@mit.edu>
References: <1324135695-15487-1-git-send-email-david@tethera.net>
	<1326197228-10356-1-git-send-email-david@tethera.net>
	<1326197228-10356-2-git-send-email-david@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1326197228-10356-2-git-send-email-david@tethera.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IRYrdT130TxedvMPE2j8XGZT+ZLW60djNa
	XL85k9mB2eNX21xmj2erbjF7bDn0njmAOYrLJiU1J7MstUjfLoErY//3iYwF55kr5m2/ztzA
	+JWpi5GTQ0LAROL9n10sELaYxIV769m6GLk4hAT2MUpMOnsYytnAKHGk4QA7SJWQwEkmiZ7V
	5hCJJYwS3Z+6wdpZBFQlTu6azwZiswloSGzbv5wRxBYBil/dNhkszixgL7Fo9iSwQcICwRJr
	n90A6+UV0JH4sWUeO8TQjYwSt+5uZ4JICEqcnPmEBaJZS+LGv5dAcQ4gW1pi+T8OkDCngJPE
	xvfLWEFsUQEViSknt7FNYBSahaR7FpLuWQjdCxiZVzHKpuRW6eYmZuYUpybrFicn5uWlFuma
	6OVmluilppRuYgQFO6ck/w7GbweVDjEKcDAq8fDu3MvrL8SaWFZcmXuIUZKDSUmU90Y4n78Q
	X1J+SmVGYnFGfFFpTmrxIUYJDmYlEV6nGqBy3pTEyqrUonyYlDQHi5I4r5rWOz8hgfTEktTs
	1NSC1CKYrAwHh5IErzYwqoUEi1LTUyvSMnNKENJMHJwgw3mAhsuD1PAWFyTmFmemQ+RPMSpK
	ifMygyQEQBIZpXlwvbBk9IpRHOgVYV4NkCoeYCKD634FNJgJaPCWdTwgg0sSEVJSDYxaa/LX
	snYvPLt6gYjZ3qa4o1Z/N0T9CVoUqexxPNquPEKPXdyy6M+DwD2fLmg4nJpt/Tc9ecKO9cW/
	I1L3R+Zmrll0bZFJe5Wow2EOruKwCdx/f4S9O8j7pvKa9gm5Uw9vm7RLeLws8hXKtYxsdotW
	26D+9Gdc3rXPMoHJhVOLC/ft6lK90KLEUpyRaKjFXFScCADyfRafIQMAAA==
Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2012 04:00:45 -0000

Quoth David Bremner on Jan 10 at  8:07 am:
> In an ideal situation, running uncrustify on notmuch code would be
> NOP; currently this is not true for all files because 1) the
> configuration is not perfect 2) the coding style of notmuch is not
> completely consistent; in particular the treatment of braces after
> e.g. for (_) is not consistent.

Do you have examples of something this gets wrong besides the funny
indentation of notmuch_show_format_t?