Return-Path: <novalazy@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 2248B431FB6
	for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 16:55:08 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 1.7
X-Spam-Level: *
X-Spam-Status: No, score=1.7 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ptsuceMBzqVb for <notmuch@notmuchmail.org>;
	Fri, 21 Jun 2013 16:54:56 -0700 (PDT)
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
	[209.85.220.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 446A0431FAE
	for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 16:54:56 -0700 (PDT)
Received: by mail-pa0-f48.google.com with SMTP id kp12so8498515pab.35
	for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 16:54:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=date:message-id:from:to:cc:subject:in-reply-to:references
	:mime-version:content-type:content-disposition
	:content-transfer-encoding;
	bh=AMjHWA/tXig6YRL74n86iS+0XyPbPIiKffv9xWxME74=;
	b=Bfanhjoc2UlxaNoBm812I67oNQzkZ1GU4KKYkT9c105MeDniRt7ErDNDGPwYf9HZR0
	kSIicNxPbfPMrccoft4T0aVxhWfPpgRCzpbAjeANGXIaMOZfHJnclZ5OpxzREHbZ+NH6
	RVsP3AdJY80mRH9W0kvpzvBBSdgzuRiFDAqGcXcOdI8UEQAad/UoI8KE8vj+cHPbi3Rf
	Ygr0qP6P/J2RIbNQ5B78AnG8e59Jw1TaqBH9EcN3BmG/axSJckm/4Pg3ADSmrAda7iTy
	nkLcmq0rbFLzK8qcELH2qW2gEGLxD1akk/i/gdKMx29xzvy56+sWr64HobougIt2i7L3
	Jc1A==
X-Received: by 10.68.223.34 with SMTP id qr2mr6770083pbc.75.1371858894395;
	Fri, 21 Jun 2013 16:54:54 -0700 (PDT)
Received: from localhost (215.42.233.220.static.exetel.com.au.
	[220.233.42.215])
	by mx.google.com with ESMTPSA id ri8sm6753646pbc.3.2013.06.21.16.54.51
	for <multiple recipients>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Fri, 21 Jun 2013 16:54:53 -0700 (PDT)
Date: Sat, 22 Jun 2013 09:55:36 +1000
Message-ID: <20130622095536.GA1996@hili.localdomain>
From: Peter Wang <novalazy@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t
In-Reply-To: <m2txkrk9ua.fsf@guru.guru-group.fi>
References: <1368301809-12532-1-git-send-email-markwalters1009@gmail.com>
	<1368301809-12532-8-git-send-email-markwalters1009@gmail.com>
	<87bo8edif8.fsf@qmul.ac.uk> <87fvwdx19x.fsf@qmul.ac.uk>
	<m2txkrk9ua.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2013 23:55:08 -0000

On Fri, 21 Jun 2013 13:59:57 +0300, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Thu, Jun 20 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> 
> > I think we should decide before 0.16 whether to go with this patch and
> > patch 8/8 or for Peter's suggestion at
> > id:1368454815-1854-1-git-send-email-novalazy@gmail.com
> >
> > Now we have an enum for the NOTMUCH_EXCLUDE possibilities (rather than a
> > bool) I think it makes sense to implement NOTMUCH_EXCLUDE_FALSE properly
> > but I am happy with either choice.
> 
> So, the choice here is to choose between
> 
> id:"1368454815-1854-1-git-send-email-novalazy@gmail.com"
> and
> id:"87bo8edif8.fsf@qmul.ac.uk" 
> 
> (might be hard to catch from this thread -- was easier to take from
> http://nmbug.tethera.net/status/ )
> 
> Both apply cleanly to current master ( d0bd88f )
> 
> While Peter's version surely looks simpler (and may work, didn't test atm)
> the comments Mark presents makes sense (especially the "subtlety" thing ;)
> 
> IMHO Mark's version makes future development "safer" and therefore my
> vote (or million of those) goes to id:"87bo8edif8.fsf@qmul.ac.uk"

Sure, I don't care.

Peter