Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 7CA9D431FB6
	for <notmuch@notmuchmail.org>; Sun,  3 Jun 2012 08:07:02 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id E6PkJ0LIRDw0 for <notmuch@notmuchmail.org>;
	Sun,  3 Jun 2012 08:07:01 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id BE13C431FAF
	for <notmuch@notmuchmail.org>; Sun,  3 Jun 2012 08:07:01 -0700 (PDT)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 51F5510014D; Sun,  3 Jun 2012 18:07:11 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] config: add quoting to fix IFS bug
In-Reply-To: <1338660961-13760-1-git-send-email-jrollins@finestructure.net>
References: <1338660961-13760-1-git-send-email-jrollins@finestructure.net>
User-Agent: Notmuch/0.13+29~g3c353b7 (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-redhat-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 03 Jun 2012 18:07:11 +0300
Message-ID: <m2bol0juxs.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jun 2012 15:07:02 -0000

On Sat, Jun 02 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

> Without proper quoting the DEFAULT_IFS was getting set incorrectly,
> which was causing problems with the storage of some variables later in
> the script.  Quoting fixes the problem.

LGTM

Tomi


> ---
> Thanks to Tomi for the inspiration for this fix.  I don't know how I
> missed such a simple solution initially.
>
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5602be2..3fad424 100755
> --- a/configure
> +++ b/configure
> @@ -1,7 +1,7 @@
>  #! /bin/sh
>  
>  # Store original IFS value so it can be changed (and restored) in many places.
> -readonly DEFAULT_IFS=$IFS
> +readonly DEFAULT_IFS="$IFS"
>  
>  srcdir=$(dirname "$0")
>  
> -- 
> 1.7.10
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch