Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1B051431FAF for ; Wed, 18 Jan 2012 10:30:48 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id msUJJojVr0bb for ; Wed, 18 Jan 2012 10:30:47 -0800 (PST) Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 69759431FAE for ; Wed, 18 Jan 2012 10:30:47 -0800 (PST) Received: by wgbdr12 with SMTP id dr12so3624555wgb.2 for ; Wed, 18 Jan 2012 10:30:44 -0800 (PST) Received: by 10.180.95.199 with SMTP id dm7mr38655061wib.9.1326911444910; Wed, 18 Jan 2012 10:30:44 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id fv6sm57760268wib.8.2012.01.18.10.30.43 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Jan 2012 10:30:43 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id A58A09FD95; Wed, 18 Jan 2012 18:30:41 +0000 (GMT) To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks. In-Reply-To: <877h0o99aj.fsf@gmail.com> References: <1326907993-11054-1-git-send-email-dme@dme.org> <1326908371-11949-1-git-send-email-dme@dme.org> <877h0o99aj.fsf@gmail.com> User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Wed, 18 Jan 2012 18:30:36 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2012 18:30:48 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin wrote: > On Wed, 18 Jan 2012 17:39:31 +0000, David Edmondson wrote: > > The `mm-inlinable-p' and `mm-inlined-p' functions work better if they > > have access to the data of the relevant part, so load that content > > before calling either function. > >=20 > > This fixes the display of attached image/jpeg parts, for example. >=20 > Not so long ago I made an opposite change to avoid fetching useless > parts (e.g. audio files). Looks like we need a better check here. Can > we know from Content-Type if fetching a part body would be useful? What if `notmuch-show-insert-part-*/*' consulted a list of content-type regexps to attempt to inline? That would allow a sane default (("image/*" "text/*") perhaps), but also allow more to be added to that list (or some to be removed), either by code that detected the (in)ability to render it or the user. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8XD80ACgkQaezQq/BJZRbPewCePw9xnhRAY472GJI7UQMDzFJo 5AEAnivXYwYlb7iX0qtII03+gFwpwvs9 =97EX -----END PGP SIGNATURE----- --=-=-=--