From: Carl Worth <cworth@cworth.org>
To: David Edmondson <dme@dme.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: pull request
In-Reply-To: <87eiibq22s.fsf@ut.hh.sledj.net>
References: <87sk722sfq.fsf@ut.hh.sledj.net> <87eiibq22s.fsf@ut.hh.sledj.net>
Date: Mon, 19 Apr 2010 11:07:40 -0700
Message-ID: <87ljcj2u4z.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson <dme@dme.org> wrote:
> This is the same set rebased onto 0.2.

Thanks for these, David!

>  commit 8586a86b9dd4ed2406a2fbda6c08bdc6a598cfd8
>     debian: git should ignore packaging intermediate files

I committed an alternate version of this, (with a new debian/.gitignore
file). I used more wildcarding too. And I couldn't actually find how to
make all these files appear. If you need more ignores, just let me know
(and let me know what commands trigger those, since I'm curious).

>  commit f5de1bb5b4216a1950f6aa5f471c9964e4d0e521
>     emacs/notmuch-show.el: Avoid passing unintended format strings to
>     `message'

Thanks. I've committed this.

> commit 4159baa2166a3410663adc200f91145edf8e0e13
>=20
>     emacs/notmuch.el: Enable `hl-line-mode' in `notmuch-search-mode'

I've got some misgivings about this one. First, notmuch-search-hook is
a hook for the user to manipulate, while the hl-line-mode functionality
is something that should be on by default. That is, if the user happens
to set the search-hook then the hl-line-mode shouldn't magically
disappear.

Meanwhile, I *am* getting hl-line-mode in notmuch-search-mode
already. I'm not sure where that's coming from. (I also don't know
what's up with the current "options '(hl-line-mode)" which doesn't seem
right.)

> commit 53c4e64943d09b07e75c9258fc9f954c87a490d6
>     json: Avoid calling strlen(NULL)

That commit message describes this hunk of the patch:

> +    if (str =3D=3D NULL)
> +       str =3D "";
> +
>     return (json_quote_chararray (ctx, str, strlen (str)));

But this other hunk looks independent. What's going on here?

> -    if (len =3D=3D 0)
> -       return (char *)"\"\"";
> -

So I haven't committed this piece yet.

That brings me up to the big JSON rewrite, which I'll start testing and
review in a separate reply.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLzJvs6JDdNq8qSWgRAkb8AJ9p6PYKZ8K/Zw2RJGP3kMtw6xlA4wCfcyes
3NP01jDOLRz36fV80gqOPwY=
=xHBO
-----END PGP SIGNATURE-----
--=-=-=--