Return-Path: <jani@nikula.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 583D2431FBC
	for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:21 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id VHApxB1r2lER for <notmuch@notmuchmail.org>;
	Tue, 28 Oct 2014 12:43:16 -0700 (PDT)
Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com
 [74.125.82.53])	(using TLSv1 with cipher RC4-SHA (128/128 bits))	(No client
 certificate requested)	by olra.theworths.org (Postfix) with ESMTPS id
 A1BB6431FB6	for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:16 -0700
 (PDT)
Received: by mail-wg0-f53.google.com with SMTP id b13so274039wgh.40
	for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:15 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:from:to:subject:in-reply-to:references
	:user-agent:date:message-id:mime-version:content-type;
	bh=S/fgXWs0ifvP5FChoiwDkjvs8LJEhWKkd4i7RSHWKJM=;
	b=CSHvUJtJKSfVsVi+jqNjokT/unk0HOYy7hPmuMuzxwphEkY7T55F28GbmIzJ40uZUW
	BcbpOpJkbqiGDiT6xTSMA04N0J1KtmDNS4UslI9xpkKKe2gKzjI5MZHhNr+tkcUBQ1ua
	jInhPV0JNaPwBYvmedphvvHdWSN5FKjsn31IcV6a+eI3AR7KRexx61In91KWNSeXBczn
	TbUOSJhkubX4sejB0/g/lqVMHBji9O6XpWpfK91qZ9QcVW+Hqa9m1QVJC/kcWF1/yXRu
	f4MMAcu2aawLEIs6K/nIMixSfW2plbb2c5xKXhB7LmRHxOaj10m9ANCheX9Rq3XJXSN6
	+Qsw==
X-Gm-Message-State:
 ALoCoQk3V8XmsME4Wq3nRMxXoDB+c+Qo46a/WpQHyZ8y7rT6Eo13Zk8P92iTmR5WzJj9GjKMZJXQ
X-Received: by 10.180.76.41 with SMTP id h9mr7490232wiw.40.1414525395324;
	Tue, 28 Oct 2014 12:43:15 -0700 (PDT)
Received: from localhost (dsl-hkibrasgw2-58c36d-48.dhcp.inet.fi.
	[88.195.109.48])
	by mx.google.com with ESMTPSA id u13sm1755264wiv.10.2014.10.28.12.43.14
	for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Tue, 28 Oct 2014 12:43:14 -0700 (PDT)
From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test
In-Reply-To: <87a94g2h7t.fsf@maritornes.cs.unb.ca>
References: <1414518754-16344-1-git-send-email-jani@nikula.org>
	<87a94g2h7t.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.18.2+148~g4214adf (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 28 Oct 2014 21:43:12 +0200
Message-ID: <877fzk0ylr.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 19:43:21 -0000

On Tue, 28 Oct 2014, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> You need to actually check the return value. Limit the missing deps
>> part to subtests requiring gdb.
>
> For me, on a system without gdb, the current version looks like
>
> T070-insert: Testing "notmuch insert"
>  missing prerequisites: gdb(1)
>  SKIP   all tests in T070-insert
>
> This seems OK to me?

More than okay. /me hides.

> Of course you're right that moving it forward to only skip the gdb
> requiring tests is the right thing to do, and in that setting having a
> skipped message for all 10 skipped tests is a bit ugly. OTOHO your
> version doesn't give any output at all, which seems not perfect either.

How does it work if you just move the prereq test forward?

BR,
Jani.