From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v2 1/7] build: drop the -Wswitch-enum warning
Date: Sat,  4 Aug 2012 10:41:39 +0300
Message-Id:
 <1045e9574656c8a3389cfee1057c3a3e2cf0b555.1344065790.git.jani@nikula.org>
In-Reply-To: <cover.1344065790.git.jani@nikula.org>
References: <cover.1344065790.git.jani@nikula.org>
In-Reply-To: <cover.1344065790.git.jani@nikula.org>
References: <cover.1344065790.git.jani@nikula.org>
Precedence: list

-Wswitch-enum is a bit awkward if a switch statement is intended to
handle just some of the named codes of an enumeration especially, and
leave the rest to the default label.

We already have -Wall, which enables -Wswitch by default, and per GCC
documentation, "The only difference between -Wswitch and this option
[-Wswitch-enum] is that this option gives a warning about an omitted
enumeration code even if there is a default label."

Drop -Wswitch-enum to not force listing all named codes of
enumerations in switch statements that have a default label.

---

This will be useful in the next patch.
---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index dc0dba4..4433f42 100755
--- a/configure
+++ b/configure
@@ -528,7 +528,7 @@ fi
 
 WARN_CXXFLAGS=""
 printf "Checking for available C++ compiler warning flags... "
-for flag in -Wall -Wextra -Wwrite-strings -Wswitch-enum; do
+for flag in -Wall -Wextra -Wwrite-strings; do
     if ${CC} $flag -o minimal minimal.c > /dev/null 2>&1
     then
 	WARN_CXXFLAGS="${WARN_CXXFLAGS}${WARN_CXXFLAGS:+ }${flag}"
-- 
1.7.9.5