Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 9D8AF431FB6
	for <notmuch@notmuchmail.org>; Sun, 13 May 2012 13:50:05 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id AIDiZhBnf9Rp for <notmuch@notmuchmail.org>;
	Sun, 13 May 2012 13:50:04 -0700 (PDT)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id 9F6AD431FAE
	for <notmuch@notmuchmail.org>; Sun, 13 May 2012 13:50:04 -0700 (PDT)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id F3F4868021; Sun, 13 May 2012 23:49:58 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] Fix notmuch_database_get_directory API
In-Reply-To: <1336939029-13969-1-git-send-email-amdragon@mit.edu>
References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.13~rc1+15~ge68de87 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 13 May 2012 23:49:58 +0300
Message-ID: <m2txzjlsax.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2012 20:50:05 -0000

On Sun, May 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:

> This is a proposed last-minute change for 0.13.  It fixes the
> notmuch_database_get_directory API in the same way we're fixing
> notmuch_database_open, etc in this release.  Since this is a
> backwards-incompatible change, it would be nice to lump it with the
> other API-breaking changes.
>
> To keep the patch simple, this does not change the behavior of
> notmuch_database_get_directory, but it puts us in a good position to
> fix it in the future.

Looks good to me (and applied in my current environment). The c/c++ 
changes were easy to understand and the python/go/ruby binding
changes looks like the old changes -- but those who understand more
(and actually uses those bindings) could do better review.

It would be nice to get those in so that we may have chance not
updating SONAME for notmuch 0.14.


Tomi