Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 912DE4196F4 for ; Fri, 14 May 2010 09:53:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[BAYES_20=-0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jGiNj+pb0tww for ; Fri, 14 May 2010 09:53:49 -0700 (PDT) Received: from homiemail-a23.g.dreamhost.com (caiajhbdcagg.dreamhost.com [208.97.132.66]) by olra.theworths.org (Postfix) with ESMTP id 3172B4196F0 for ; Fri, 14 May 2010 09:53:49 -0700 (PDT) Received: from sspaeth.de (p172-25-143-0.nat.washington.edu [205.175.121.143]) (Authenticated sender: sebastian@sspaeth.de) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTPA id 6CC1D4B0080; Fri, 14 May 2010 09:53:47 -0700 (PDT) Received: by sspaeth.de (sSMTP sendmail emulation); Fri, 14 May 2010 09:53:46 -0700 From: "Sebastian Spaeth" To: Nelson Elhage Subject: Re: [PATCH] emacs: notmuch-hello: Use our own keymap. In-Reply-To: <20100514033434.GA5072@ksplice.com> References: <1273805175-6660-1-git-send-email-nelhage@ksplice.com> <774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de> <20100514033434.GA5072@ksplice.com> User-Agent: Notmuch/0.3.1-16-g417274d (http://notmuchmail.org) Emacs/23.1.1 (x86_64-pc-linux-gnu) Date: Fri, 14 May 2010 09:53:46 -0700 Message-ID: <877hn6zap1.fsf@SSpaeth.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2010 16:53:59 -0000 On 2010-05-14, Nelson Elhage wrote: > Ah, I failed to properly search the mail archives before sending > this. No problem, I admit that my subject title does not obviously point out that it creates a proper keymap ;-). > Your patch looks preferable with one exception: I think that > making widget-keymap a parent of notmuch-hello-mode-map is probably > better than just copying widget-keymap. That sounds good to me. I am generally an elisp newbie and was just using the first approach that worked for me. Do you want to update the patch? Sebastian