Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0F85F431FAF for ; Sat, 4 Feb 2012 12:14:28 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2gPqkKPdDa-S for ; Sat, 4 Feb 2012 12:14:27 -0800 (PST) Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) by olra.theworths.org (Postfix) with ESMTP id 418DB431FAE for ; Sat, 4 Feb 2012 12:14:27 -0800 (PST) Received: by guru.guru-group.fi (Postfix, from userid 501) id D8C9568055; Sat, 4 Feb 2012 22:14:25 +0200 (EET) From: Tomi Ollila To: Mark Walters , David Edmondson , notmuch@notmuchmail.org Subject: Re: Bug: emacs 23.2 doesn't like ido-completing-read In-Reply-To: <8762fmeq4i.fsf@qmul.ac.uk> References: <871uqijdy4.fsf@qmul.ac.uk> <87pqe14hjh.fsf@qmul.ac.uk> <8762fmeq4i.fsf@qmul.ac.uk> User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2012 20:14:28 -0000 On Sat, 04 Feb 2012 12:31:57 +0000, Mark Walters wrote: > > I hadn't realised before but this also goes wrong if you use the prefix > argument to mail (eg ctrl-u m). The current code seems to mess up the > mini-buffer and even closing the buffer does not get out of it. > > Changing ido-completing-read read to completing-read seems to fix the > problem entirely. Since this will affect most debian stable users (*) I > think we should fix it. The trivial patch below works for me but other solutions > may be better as they could maintain the benefits of ido-completing-read > (eg that it shows the possibilities). > > Best wishes > > Mark > > (*) Perhaps only those who have more than one email address. > > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index 023645e..41f82c2 100644 > --- a/emacs/notmuch-mua.el > +++ b/emacs/notmuch-mua.el > @@ -191,7 +191,7 @@ the From: header is already filled in by notmuch." > ;; Now prompt the user, either for an email address only or for a full identity. > (if one-name-only > (let ((address > - (ido-completing-read (concat "Sender address for " name ": ") addresses > + (completing-read (concat "Sender address for " name ": ") addresses > nil nil nil 'notmuch-mua-sender-history (car addresses)))) > (concat name " <" address ">")) > (ido-completing-read "Send mail From: " notmuch-identities Should that other ido-completing-read be kept there -- it is the only one left after this patch... Tomi > -- > 1.7.2.3