Date: Thu, 24 May 2012 17:57:06 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH v3 3/4] new: Merge error checks from add_files and
	add_files_recursive
Message-ID: <20120524215706.GA11804@mit.edu>
References: <1336429240-1114-1-git-send-email-amdragon@mit.edu>
	<1337887922-13163-1-git-send-email-amdragon@mit.edu>
	<1337887922-13163-4-git-send-email-amdragon@mit.edu>
	<87wr415mc3.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wr415mc3.fsf@nikula.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Jani Nikula on May 24 at 11:57 pm:
> On Thu, 24 May 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> > Before XXX, add_files_recursive could have been called on a symlink to
> > a non-directory.  Hence, calling it on a non-directory was not an
> > error, so a separate function, add_files, existed to fail loudly in
> > situations where the path had to be a directory.
> 
> "Before XXX"?

Arg.  I meant to replace that with a commit ID, but now I don't
remember what commit I wanted to reference.

> Otherwise, this 3/4 and following 4/4 patch LGTM. I didn't bother
> looking at 1/4 and 2/4 again, as you say there were no changes.
> 
> 
> BR,
> Jani.