Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C825A429E26 for ; Thu, 12 Jan 2012 09:08:03 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o7rOh7Iqir6c for ; Thu, 12 Jan 2012 09:08:00 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 0CD7F431FB6 for ; Thu, 12 Jan 2012 09:07:59 -0800 (PST) Received: by wibhr12 with SMTP id hr12so1498430wib.26 for ; Thu, 12 Jan 2012 09:07:58 -0800 (PST) Received: by 10.180.106.165 with SMTP id gv5mr7582848wib.18.1326388078860; Thu, 12 Jan 2012 09:07:58 -0800 (PST) Received: from localhost ([109.131.126.209]) by mx.google.com with ESMTPS id q7sm915386wix.5.2012.01.12.09.07.57 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Jan 2012 09:07:58 -0800 (PST) From: Pieter Praet To: Jani Nikula Subject: Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace In-Reply-To: References: <87zkfwn4lm.fsf@zancas.localnet> <1321475870-29674-1-git-send-email-pieter@praet.org> <1321475870-29674-3-git-send-email-pieter@praet.org> <87d3crd9yr.fsf@praet.org> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Thu, 12 Jan 2012 18:06:14 +0100 Message-ID: <87obu8luk9.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Tomi Ollila , Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 17:08:03 -0000 On Thu, 17 Nov 2011 08:21:59 +0200, Jani Nikula wrote: > On Nov 16, 2011 11:39 PM, "Pieter Praet" wrote: > > > > On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila > wrote: > > > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet > wrote: > > > > No further explanation needed. > > > > --- > > > > NEWS | 14 +++++++------- > > > > 1 files changed, 7 insertions(+), 7 deletions(-) > > > > > > The 'No further explanation needed.' should be *BELOW* the waistline > (---) ;); > > > now it goes to the commit message which is probably not what anybody > wants. > > > > > > > That was intended :) > > > > Empty commit messages are frowned upon (even if the commit subject is > > sufficiently descriptive), so "rather a pointless one than none?" :) > > Generally I think the message should be self-contained and understandable > without the subject line, so IMHO a full meaningful sentence is better than > one/none, even if it's repetition. > > BR, > Jani. That would indeed have been the most sensible thing to do. Could someone (who -unlike me- has already submitted his/her public SSH key for commit access) add something along those lines to the Patch Formatting guidelines [1] ? Perhaps just quote Carl's statement [2] ? Peace -- Pieter [1] http://notmuchmail.org/patchformatting/ [2] id:"87ocmwok2w.fsf@yoom.home.cworth.org"