From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [WIP PATCH] emacs: hello: bugfix for saved searches defcustom
In-Reply-To: <1397627927-9692-1-git-send-email-markwalters1009@gmail.com>
References: <1397627927-9692-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.17+200~gd83a69b (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 16 Apr 2014 07:51:47 -0300
Message-ID: <8738hdwnr0.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Mark Walters <markwalters1009@gmail.com> writes:

> ---
> Hi
>
> David found a bug in the recent notmuch hello saved searches and
> reduced to a small test case. The problem occurs if the user sets
> notmuch-saved-searches and then loads notmuch. The reason is that the
> defcustom calls some utility functions and these need to be defined
> (not just declared) when the defcustom is encountered.
>
> This patch moves the code around so that they are defined first. I
> have marked the patch WIP as I am not sure what the best reordering
> is, and we may want to rename some functions which have changed file
> for namespace reasons.
>
> Anyway this fixes the test case. If it fixes the original bug too then
> I will provide a better version.

Hi Mark;

This fixes the problem for me.

Thanks for your efforts,

d