From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Ruben Pollan <meskio@sindominio.net>
In-Reply-To: <20100323143714.GE28596@blackspot>
References: <1268926780-20045-1-git-send-email-sojkam1@fel.cvut.cz>
	<1268926780-20045-4-git-send-email-sojkam1@fel.cvut.cz>
	<20100323105644.GB28596@blackspot> <878w9jcga6.fsf@steelpick.2x.cz>
	<20100323143714.GE28596@blackspot>
Date: Fri, 26 Mar 2010 22:41:44 +0100
Message-ID: <87tys292w7.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH 3/4] Add maildir-based mailstore
Precedence: list

On Tue, 23 Mar 2010, Ruben Pollan wrote:
> On 14:35, Tue 23 Mar 10, Michal Sojka wrote:
> > Yes, that's a bug. Messages in your mail_folder/new probably don't have
> > any 'info' (flags) in their filename, which is correct with respect to
> > http://cr.yp.to/proto/maildir.html. My patch incorrectly ignores the
> > files without 'info'. I didn't catch this error because is seems that
> > offlineimap puts 'info' part even to messages in new/.
> 
> True, I use fetchmail for download my email, it put the email in the new folder
> without 'info'.
> 
> > I think that the correct fix for this is to change how notmuch new
> > works: Whenever a message in new/ is found, it will be moved to cur/ and
> > in there is no info part it will be appended and the message will be
> > tagged accordingly.
> 
> I think is better if new keeps the email where it is, only updates the database,
> and when you remove the unread tag move the message from folder to folder. Some 
> mail readers (at least mutt) handles different the emails on the new folder than
> the ones with no "S" flag con cur folder.
> 
> > I'll try to implement it and send a new patch.
> 
> That will be nice.

Hi,

Here is the updated patch series implementing your proposal. Let me know
if it solves your problem.

I also did some minor cleanups and included "Prevent data loss caused by
SIGINT during notmuch new" patch which I've just sent separately.

-Michal