Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 24E57429E5B for ; Mon, 23 Jan 2012 01:12:22 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nB2uVZV0pvLA for ; Mon, 23 Jan 2012 01:12:21 -0800 (PST) Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7069C429E54 for ; Mon, 23 Jan 2012 01:12:21 -0800 (PST) Received: by wgbdt11 with SMTP id dt11so2589677wgb.2 for ; Mon, 23 Jan 2012 01:12:20 -0800 (PST) Received: by 10.180.100.234 with SMTP id fb10mr12913929wib.5.1327309940293; Mon, 23 Jan 2012 01:12:20 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id q7sm11759931wix.5.2012.01.23.01.12.18 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Jan 2012 01:12:19 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id DF7DCA0950; Mon, 23 Jan 2012 09:12:16 +0000 (GMT) To: Jameson Graef Rollins Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. In-Reply-To: <87ipk22439.fsf@servo.finestructure.net> References: <1327052612-1040-1-git-send-email-dme@dme.org> <1327052612-1040-2-git-send-email-dme@dme.org> <877h0jmn9a.fsf@servo.finestructure.net> <87ipk22439.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+73~gd51b784 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Mon, 23 Jan 2012 09:12:13 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: notmuch X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 09:12:22 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 23 Jan 2012 00:52:26 -0800, Jameson Graef Rollins wrote: > On Mon, 23 Jan 2012 08:16:03 +0000, David Edmondson wrote: > > There was no problem with the logic. The code in the two functions was > > almost identical, so I'd like to make any future changes in just one > > place. > > > > You didn't actually answer my question - is the logic in the new > > function correct? >=20 > Honestly I didn't look too closely yet since I'm not convinced we need > the change at all. I would prefer to keep the functions separate. In > my opinion, enough special casing would be required that it wouldn't be > worth it, and it would make the code less clear. Okay. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8dJG0ACgkQaezQq/BJZRbO/QCdHPWe9hYLGNb4XIGGu2JlCrMB 0mIAn3fRdxmFfmYu+OH+atVFM8zJggu3 =2Vi0 -----END PGP SIGNATURE----- --=-=-=--