Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6DC28431FAF for ; Tue, 27 Mar 2012 13:01:25 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2g47rz0KsJ0t for ; Tue, 27 Mar 2012 13:01:23 -0700 (PDT) Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) by olra.theworths.org (Postfix) with ESMTP id 07DA3431FAE for ; Tue, 27 Mar 2012 13:01:22 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id D906B68055; Tue, 27 Mar 2012 23:01:19 +0300 (EEST) From: Tomi Ollila To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring In-Reply-To: References: User-Agent: Notmuch/0.12+70~gce7ecf1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2012 20:01:25 -0000 On Tue, Mar 27 2012, Jani Nikula wrote: > v3 of id:"cover.1332702915.git.jani@nikula.org" with the following > mostly non-functional changes: > > - add test for the current tagging behaviour in patch 1, and change the > test in patch 2 when the behaviour is changed > - handle the no tag changes case in _optimize_tag_query() in patch 2 > - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');" > assignment > - document the tag_query() function a bit in patch 3 > - make tag_message() static in patch 4 LGTM. > > BR, > Jani. Tomi > > > Jani Nikula (4): > test: add test for both adding and removing a tag at the same time > cli: refactor "notmuch tag" data structures for tagging operations > cli: refactor "notmuch tag" query tagging into a separate function > cli: refactor "notmuch restore" message tagging into a separate > function > > notmuch-restore.c | 148 ++++++++++++++++++++++++--------------------- > notmuch-tag.c | 173 ++++++++++++++++++++++++++++------------------------- > test/tagging | 8 +++ > 3 files changed, 178 insertions(+), 151 deletions(-) > > -- > 1.7.5.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch