From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/2] test: add known broken tests for known broken RFC
	2047 encodings
In-Reply-To: <1378921003-14639-1-git-send-email-jani@nikula.org>
References: <8738pcjet4.fsf@awakening.csail.mit.edu>
	<1378921003-14639-1-git-send-email-jani@nikula.org>
User-Agent: Notmuch/0.16+76~ga4151ca (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 11 Sep 2013 22:57:41 +0300
Message-ID: <m2r4cvyvuy.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Wed, Sep 11 2013, Jani Nikula <jani@nikula.org> wrote:

> Some common broken RFC 2047 encodings that we currently let gmime
> parse strictly. We could tell gmime to be forgiving in what it accepts
> as RFC 2047 encoding, making these tests pass.
> ---

V2 LGTM.

Tomi

>  test/encoding | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/test/encoding b/test/encoding
> index 2e1326e..7372b6b 100755
> --- a/test/encoding
> +++ b/test/encoding
> @@ -29,4 +29,22 @@ add_message '[content-type]=3D"text/plain; charset=3Di=
so-8859-2"' \
>  output=3D$(notmuch search tu=C4=8D=C5=88=C3=A1=C4=8D=C4=8D=C3=AD 2>&1 | =
notmuch_show_sanitize)
>  test_expect_equal "$output" "thread:0000000000000002   2001-01-05 [1/1] =
Notmuch Test Suite; ISO-8859-2 encoded message (inbox unread)"
>=20=20
> +test_begin_subtest "RFC 2047 encoded word with spaces"
> +test_subtest_known_broken
> +add_message '[subject]=3D"=3D?utf-8?q?encoded word with spaces?=3D"'
> +output=3D$(notmuch search id:${gen_msg_id} 2>&1 | notmuch_show_sanitize)
> +test_expect_equal "$output" "thread:0000000000000003   2001-01-05 [1/1] =
Notmuch Test Suite; encoded word with spaces (inbox unread)"
> +
> +test_begin_subtest "RFC 2047 encoded words back to back"
> +test_subtest_known_broken
> +add_message '[subject]=3D"=3D?utf-8?q?encoded-words-back?=3D=3D?utf-8?q?=
to-back?=3D"'
> +output=3D$(notmuch search id:${gen_msg_id} 2>&1 | notmuch_show_sanitize)
> +test_expect_equal "$output" "thread:0000000000000004   2001-01-05 [1/1] =
Notmuch Test Suite; encoded-words-backto-back (inbox unread)"
> +
> +test_begin_subtest "RFC 2047 encoded words without space before or after"
> +test_subtest_known_broken
> +add_message '[subject]=3D"=3D?utf-8?q?encoded?=3Dword without=3D?utf-8?q=
?space?=3D" '
> +output=3D$(notmuch search id:${gen_msg_id} 2>&1 | notmuch_show_sanitize)
> +test_expect_equal "$output" "thread:0000000000000005   2001-01-05 [1/1] =
Notmuch Test Suite; encodedword withoutspace (inbox unread)"
> +
>  test_done
> --=20
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch