From: David Bremner <david@tethera.net>
To: Mayeu <ml+notmuch@6x9.fr>
Subject: Re: Notmuch removing messages from the index, when calling `new` two
 times in a row
In-Reply-To: <20150424112914.5ffef31c@azathoth>
References: <87y4llpiom.fsf@azathoth.devlab.ch>
 <87mw1z8pxu.fsf@maritornes.cs.unb.ca>
 <87fv7ruk2j.fsf@azathoth.i-did-not-set--mail-host-address--so-tickle-me>
 <87oame7a93.fsf@maritornes.cs.unb.ca> <20150424112914.5ffef31c@azathoth>
User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1
 (x86_64-pc-linux-gnu)
Date: Mon, 27 Apr 2015 08:45:03 +0900
Message-ID: <87k2wybgjk.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain

Mayeu <ml+notmuch@6x9.fr> writes:

> On Fri, 24 Apr 2015 07:25:28 +0900
> David Bremner <david@tethera.net> wrote:
>> OK. Please try running "notmuch new" (the second time) with --debug.
>
> The output is exactly the same, no other information. I also tried to
> add --verbose but same output. Both are accepted as valid since I do
> net get back any error, but the output is not changed.
>

I think there is just not enough debugging output in this part of the
code. If you can compile from source, please try the attached patch
(it's against master, but I guess it should apply to 0.19 as well).


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-cli-new-add-more-debugging-output.patch

>From 52975ecfdc754863e9ac9b465257a566845377c3 Mon Sep 17 00:00:00 2001
From: David Bremner <david@tethera.net>
Date: Mon, 27 Apr 2015 08:42:36 +0900
Subject: [PATCH] cli/new: add more debugging output

Try to narrow down what part of the code adds files and directories to
the queue(s) to be deleted.
---
 notmuch-new.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/notmuch-new.c b/notmuch-new.c
index e6c283e..39b0b9a 100644
--- a/notmuch-new.c
+++ b/notmuch-new.c
@@ -528,6 +528,10 @@ add_files (notmuch_database_t *notmuch,
 					      "%s/%s", path,
 					      notmuch_filenames_get (db_files));
 
+	    if (state->debug)
+		printf ("(D) add_files_recursive, pass 2: queuing passed file %s for deletion\n",
+			absolute);
+
 	    _filename_list_add (state->removed_files, absolute);
 
 	    notmuch_filenames_move_to_next (db_files);
@@ -542,6 +546,9 @@ add_files (notmuch_database_t *notmuch,
 	    {
 		char *absolute = talloc_asprintf (state->removed_directories,
 						  "%s/%s", path, filename);
+		if (state->debug)
+		    printf ("(D) add_files_recursive, pass 2: queuing passed directory %s for deletion\n",
+			absolute);
 
 		_filename_list_add (state->removed_directories, absolute);
 	    }
@@ -610,6 +617,9 @@ add_files (notmuch_database_t *notmuch,
 	char *absolute = talloc_asprintf (state->removed_files,
 					  "%s/%s", path,
 					  notmuch_filenames_get (db_files));
+	if (state->debug)
+	    printf ("(D) add_files_recursive, pass 3: queuing leftover file %s for deletion\n",
+		    absolute);
 
 	_filename_list_add (state->removed_files, absolute);
 
@@ -622,6 +632,10 @@ add_files (notmuch_database_t *notmuch,
 					  "%s/%s", path,
 					  notmuch_filenames_get (db_subdirs));
 
+	if (state->debug)
+	    printf ("(D) add_files_recursive, pass 3: queuing leftover directory %s for deletion\n",
+		    absolute);
+
 	_filename_list_add (state->removed_directories, absolute);
 
 	notmuch_filenames_move_to_next (db_subdirs);
-- 
2.1.4


--=-=-=--