Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B7720431FBD for ; Sat, 27 Jul 2013 14:52:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2pjrvmU9mYMb for ; Sat, 27 Jul 2013 14:52:55 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 933B4431FBC for ; Sat, 27 Jul 2013 14:52:55 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1V3CQ1-000681-0C; Sat, 27 Jul 2013 18:52:53 -0300 Received: (nullmailer pid 11360 invoked by uid 1000); Sat, 27 Jul 2013 21:52:49 -0000 From: David Bremner To: Mark Walters Subject: Re: [PATCH] emacs: hello: make --batch error gracefully In-Reply-To: <87ob9svghw.fsf@zancas.localnet> References: <1372976299-30389-1-git-send-email-markwalters1009@gmail.com> <87ob9svghw.fsf@zancas.localnet> User-Agent: Notmuch/0.15.2+226~ge395f45 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 27 Jul 2013 18:52:49 -0300 Message-ID: <87a9l7oeku.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain Cc: notmuch mailing list X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2013 21:52:59 -0000 David Bremner writes: > I had a look at this, and I agree the current failure mode is not nice > (it just says something mysterious about nil not being a string). On the > other hand, I think we should use the two argument form of > notmuch-logged-error, and the the first argument should say only what we > know. Something like > > (notmuch-logged-error "notmuch count --batch failed" > "notmuch count --batch failed > Please check that the notmuch CLI is new enough to support `count > --batch'. In general we recommend running matching versions of the CLI > and emacs interface.") I pushed an amended version along these lines; it turns out the first argument does not need to be repeated. d