Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To: Austin Clements <amdragon@MIT.EDU>, 
From: Justus Winter <4winter@informatik.uni-hamburg.de>
In-Reply-To: <20120509180700.GA11804@mit.edu>
References:
 <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<20120509180700.GA11804@mit.edu>
Message-ID: <20120510143650.5975.92158@thinkbox.jade-hamburg.de>
User-Agent: alot/0.3+
Subject: Re: Last minute fixes to the go bindings
Date: Thu, 10 May 2012 16:36:50 +0200
Cc: notmuch@notmuchmail.org
Precedence: list

Quoting Austin Clements (2012-05-09 20:07:00)
> LGTM.
> =

> Quoth Justus Winter on May 09 at 12:23 pm:
> > Hi everyone :)
> > =

> > this is a small patch series that I'd like to see included in 0.13.
> > =

> > The first patch updates notmuch-addrlookup with respect to Austins
> > recent change of the notmuch_database_open function. This fixes the
> > compilation of the utility.
> > =

> > The second patch fixes the values of all the STATUS_* constants. Turns
> > out all of them were set to zero by accident. This isn't a c style
> > enum, golang has the iota operator to do this kind of stuff. This
> > fixes the error handling for all the users of the go bindings.
> =

> 'Doh!  Is it possible to get the status values out of cgo, rather than
> depending on the list in libnotmuch and the list in Go being in the
> same order?

Yes, it is and I've prepared a patch. But since I'm living in go 1
land here I prepared it on top of my go 1 patchset and I'm thinking of
sending it once that one got merged.

@David: what do you think about merging this patch set?

Justus