Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4E579431FD0 for ; Thu, 23 Jun 2011 16:33:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xyHm3jvPrH-a for ; Thu, 23 Jun 2011 16:33:20 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id E2E1F431FB6 for ; Thu, 23 Jun 2011 16:33:19 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E4FFC29A50E; Thu, 23 Jun 2011 16:33:18 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id CFEF0254157; Thu, 23 Jun 2011 16:33:18 -0700 (PDT) From: Carl Worth To: Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH] Do not attept to output part raw if part is not GMimePart. In-Reply-To: <1307120466-4980-1-git-send-email-jrollins@finestructure.net> References: <1307032735-27427-1-git-send-email-jrollins@finestructure.net> <1307120466-4980-1-git-send-email-jrollins@finestructure.net> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Thu, 23 Jun 2011 16:33:18 -0700 Message-ID: <87wrgccedd.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 23:33:20 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 3 Jun 2011 10:01:06 -0700, Jameson Graef Rollins wrote: > This was a minor oversite in checking of part type when outputing > content raw. This was causing gmime was to throw an exception to > stderr. >=20 > Unfortunately the gmime exception was not being caught by notmuch, or > the test suite. I'm not sure if notmuch should have done anything in > this case, but certainly the test suite should be capable of detecting > that something unexpected was output to stderr. I'd like to investigate this case a little bit to help answer the question of whether "notmuch should have done anything in this case". But if I apply the patch then I won't be able to. ;-) Can you give me instructions for how to replicate this bug before I apply the patch? =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk4DzT4ACgkQ6JDdNq8qSWhujgCgiGP780IqR8a7ldDQ5XxaBiIp ZtIAn0ahBFzCXMQEhliSgkeDq1sCn72S =vx+z -----END PGP SIGNATURE----- --=-=-=--