From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Edmondson <dme@dme.org>, Pieter Praet <pieter@praet.org>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle
	visibility
In-Reply-To: <cunhazknvbe.fsf@hotblack-desiato.hh.sledj.net>
References: <1327469139-1968-1-git-send-email-pieter@praet.org>
	<cunhazknvbe.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.11+116~g34d80c9 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 25 Jan 2012 15:03:30 +0200
Message-ID: <m2aa5c7x3x.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Wed, 25 Jan 2012 06:35:33 +0000, David Edmondson <dme@dme.org> wrote:
> On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet <pieter@praet.org> wrote:
> > * emacs/notmuch-show.el (notmuch-show-open-or-close-all):
> >   Rename to `notmuch-show-toggle-all-messages', and make it toggle
> >   visibility of all messages based on the visibility of the current
> >   message, instead of setting visibility based on whether or not a
> >   prefix arg was supplied.
> > 
> > Same functionality, less effort (reaching for 'C-u' is a pain)...
> 
> -1.
> 
> The behaviour you've provided is not what I want, from two perspectives:
>         - currently it's clear what will happen when I use M-RET or
>           C-uM-RET without me having to think about whether the cursor
>           is over an open message,
>         - often I'll be reading an open message and I want to open all
>           of the rest to look at some context. That's a little more
>           awkward after this change.

Yes, let's just switch. c-u M-RET to expand and M-RET to collapse (!!!)

(Needless to say I've never expanded but often collapsed ;)

Tomi