From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag
In-Reply-To: <87zkd6pzg2.fsf@qmul.ac.uk>
References: <20120124011609.GX16740@mit.edu>
	<1327367923-18228-2-git-send-email-markwalters1009@gmail.com>
	<20120124024521.GY16740@mit.edu> <874nvg6qxn.fsf@qmul.ac.uk>
	<20120128183340.GD17991@mit.edu> <8739azqt2j.fsf@qmul.ac.uk>
	<87zkd6pzg2.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.11+136~g15d04f0 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Sun, 29 Jan 2012 18:36:10 +0000
Message-ID: <8762fu4aqt.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list


Ok I now have a patch set which might be complete enough to be worth
reviewing. It is essentially complete and appears to work.

Things that still need doing: 
       updating the test suite. The series changes notmuch-show to
       output the exclude flag so several tests need updating. Of
       course, the new functionality needs some tests too.
       
       emacs/notmuch.el I think it would be nice to hide (make
       invisible) threads with no matching non-excluded messages (with a
       toggle for visibility) but that is definitely beyond my elisp
       skills.

The first patch of the series is not really part of the series: it adds
a --do-not-exclude option to tell the command not to exclude. I think
this is useful anyway, but it also simplifies behaviour decisions with
the excludes. For example notmuch count will only count matching
non-excluded messages but notmuch count --do-not-exclude will count 
all matching messages excluded or not.

One outstanding issue is that raised in
id:"20120124025331.GZ16740@mit.edu". I will need to think about
that. 

Best wishes

Mark