From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Michal Sojka <sojkam1@fel.cvut.cz>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v3 10/10] cli: address: Add --filter-by option
	to	configure	address filtering
In-Reply-To: <87vbkrfs66.fsf@maritornes.cs.unb.ca>
References: <1415147159-19946-1-git-send-email-sojkam1@fel.cvut.cz>
	<1415147159-19946-11-git-send-email-sojkam1@fel.cvut.cz>
	<87vbkrfs66.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 01 Jan 2015 14:03:47 +0200
Message-ID: <m2d26yhfmk.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Wed, Dec 31 2014, David Bremner <david@tethera.net> wrote:

> Michal Sojka <sojkam1@fel.cvut.cz> writes:
>
>> This option allows to configure the criterion for duplicate address
>> filtering. Without this option, all unique combinations of name and
>> address parts are printed. This option allows to filter the output
>> more, for example to only contain unique address parts.
>
> I had the feeling there was some "controversy" about the UI here, but
> following back the 3 versions of the series I didn't see it. Does that
> mean we just need to sanity check the code, or are there outstanding
> bikes to shed?

I have intentionally been guiet on this during the review process of the
other patches to not slow down the acceptance of the others. I have not
got enough time to look the implemenentation or think this last patch
further -- from the user interface point of view I recall seeing there
both useless features (but which might be warranted by implementation
simplicity) and missing features (but which might not be there due to 
difficulty in implementation). Also, I am not sure whether the --filter-by
is good option (and options descriptive...)...

...I'll look into this soon....


>
> d

Tomi