Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id ACC6D431FAE for ; Fri, 4 Dec 2009 05:55:51 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AdcXpAf5Yek1 for ; Fri, 4 Dec 2009 05:55:51 -0800 (PST) Received: from pivot.cs.unb.ca (pivot.cs.unb.ca [131.202.240.57]) by olra.theworths.org (Postfix) with ESMTP id 3CBA6431FBC for ; Fri, 4 Dec 2009 05:55:51 -0800 (PST) Received: from localhost ([127.0.0.1] helo=pivot.cs.unb.ca ident=bremner) by pivot.cs.unb.ca with esmtp (Exim 4.69) (envelope-from ) id 1NGYdS-0008Dw-3H; Fri, 04 Dec 2009 09:55:50 -0400 Date: Fri, 04 Dec 2009 09:55:45 -0400 Message-ID: <87k4x29732.wl%bremner@pivot.cs.unb.ca> From: david@tethera.net To: Carl Worth In-Reply-To: <87zl5zfty5.fsf@yoom.home.cworth.org> References: <1259267025-28733-1-git-send-email-dottedmag@dottedmag.net> <1259788526-14205-1-git-send-email-dottedmag@dottedmag.net> <87zl5zfty5.fsf@yoom.home.cworth.org> User-Agent: SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Sender-Verified: bremner@pivot.cs.unb.ca Cc: notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH (rebased)] Handle message renames in mail spool X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 13:55:51 -0000 At Thu, 03 Dec 2009 16:45:22 -0800, > Anyway, I think we'll see code for that soon, so I'm not planning to > commit the offered patch. But people really needing renames might want > to use it for now, (and live with any performance implications it > causes). I could live with the performance issues, but it seems that it re-tags every "Processed" file (renamed or not) as inbox. This brings about 20k messages back into my inbox, which is a bit unusable. The problem seems to be that notmuch_database_add_message returns NOTMUCH_STATUS_SUCCESS whether or not a new message was really added. I don't know if there is an easy fix for this, or if it is worth pursuing, given that the patch won't be committed. d P.S. do people want to be CC'd on this list, or not?