Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0F61D431FD0 for ; Fri, 3 Jun 2011 14:10:56 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CPOdqE3VWSXp for ; Fri, 3 Jun 2011 14:10:55 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id AA220431FB6 for ; Fri, 3 Jun 2011 14:10:55 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 635F429A5CC; Fri, 3 Jun 2011 14:10:54 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 557B325417E; Fri, 3 Jun 2011 14:10:54 -0700 (PDT) From: Carl Worth To: Dmitry Kurochkin , Notmuch Mail Subject: Re: [PATCH 1/2] Make `notmuch-show-clean-address' parsing-error-proof. In-Reply-To: <1305208586-24689-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1305208586-24689-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Fri, 03 Jun 2011 14:10:54 -0700 Message-ID: <87ipsmlixt.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2011 21:10:56 -0000 --=-=-= On Thu, 12 May 2011 17:56:25 +0400, Dmitry Kurochkin wrote: > Mail-header-parse-address may fail for an invalid address. > Before the change, this would result in empty notmuch-show buffer > with an error message like: Scan error: "Unbalanced parentheses". > The patch wraps the function in condition-case and returns > unchanged address in case of error. Thanks for the patch, Dmitry. I've just pushed this. And thanks as well for the test case. I actually pushed the test-case commit before the bug-fix commit. I like to do things in that order so that I can: 1. Apply the new test case 2. Run "make test" and see the failure 3. Apply the bug fix 4. Run "make test" and see the test pass With a sequence like that, it's very easy for me to feel very comfortable committing the code. -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3pTd4ACgkQ6JDdNq8qSWjuxQCgj6A73s9t7h306Nu65U3wmSft Rw0AmwWjSxMdzCCACVV9yfjihZJutbqF =d3/9 -----END PGP SIGNATURE----- --=-=-=--