From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: content-type comparison should be case
 insensitive.
In-Reply-To: <1332636208-9784-1-git-send-email-markwalters1009@gmail.com>
References:
 <CAMoJFUuGS_y4Sqtug5Ohdic3M43_fexWOt7cAw-ebuZ_SVUnjQ@mail.gmail.com>
	<1332636208-9784-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.11.1+335~gf868783 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 26 Mar 2012 08:21:55 -0700
Message-ID: <87398vl758.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Sun, 25 Mar 2012 00:43:28 +0000, Mark Walters <markwalters1009@gmail.com=
> wrote:
> The function notmuch-match-content-type was comparing content types
> case sensitively. Fix it so it tests case insensitively.
>=20
> This fixes a bug where emacs would not include any body when replying
> to a message with content-type TEXT/PLAIN.
> ---
>  emacs/notmuch-lib.el |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index c146748..a754de7 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -185,8 +185,9 @@ the user hasn't set this variable with the old or new=
 value."
>  	(st2 (notmuch-split-content-type t2)))
>      (if (or (string=3D (cadr st1) "*")
>  	    (string=3D (cadr st2) "*"))
> -	(string=3D (car st1) (car st2))
> -      (string=3D t1 t2))))
> +	;; Comparison of content types should be case insensitive.
> +	(string=3D (downcase (car st1)) (downcase (car st2)))
> +      (string=3D (downcase t1) (downcase t2)))))
>=20=20
>  (defvar notmuch-multipart/alternative-discouraged
>    '(

LGTM.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPcImTAAoJEO00zqvie6q8QCMP/R0qn1Q/YfFpoFf/tB841OlF
+L75SUTVlTPDJRW3t+fNIR5QhPKn88Vv97SpXPAuDmA+N8cVTKS/X05DfuwdFE0u
XbsfuyaCRmQk9Wu9+GTevqlcZCZR+BsZDVc5vvi4o5zVPtBtRLbSO0KzNkbjvv7L
5QbpRMR5M+pQKb+vSIQ5R9uKU5OMHymFGsRMKcEaEImMTqgx5Dj+L5PN//s4RaYT
oiQ+ehVOidN3YaUkL2VH6JGIU6H1dplT3HApKgmYdyYXqtiYC4wFE/CJ8DyvPrlP
AFVzm1EyxCXm0/+SymbdZTpuj4rym32qO4Nf6g68bSA+g10Aq+9Nvr8Bn0EJRkrj
sbLfuiXeWig0WTFPoKBDDReR5eOV5C4OBHdffdTT17MRX03swX0NM9MsOsDegfPl
i/UFVp/3a+EAqlvJVtIhn5L7szfnSfrUhUD623ZbfF1iQxMHAAu6tu8Ca9VtqVYZ
WYnsrL8u3YPoJqCI6+euABboOcQ1CWRbvhK4Y/uyzFVH5XHXWCt/WLB3hNZdluoO
MRl1hWnRuGTQ/AmK+3PHgl292SKupjKTAtoFysuNe0YQoLvwmnZW81A19L1Bs8Tw
DsaoGAWBs9opEHg/0me/QX6mxn09LUeiROz96xImWdDC0YCqFyP/P+WuY8ZR0TrK
NYTw34IxHkkER0hRF7Gu
=ldx5
-----END PGP SIGNATURE-----
--=-=-=--