From: Carl Worth <cworth@cworth.org>
To: david@tethera.net, notmuch@notmuchmail.org
In-Reply-To: <1262272660-16786-1-git-send-email-david@tethera.net>
References: <id:1262249616-sup-3911@elise>
	<1262272660-16786-1-git-send-email-david@tethera.net>
Date: Tue, 23 Feb 2010 12:56:15 -0800
Message-ID: <877hq3wu1c.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Subject: Re: [notmuch] [PATCH] Add an "--format=(json|text)" command-line
 option to both notmuch-search and notmuch-show.
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Thu, 31 Dec 2009 11:17:40 -0400, david@tethera.net wrote:
> This is an updated version of Scott Robinson's patch of
> id:1261114167-sup-8228@lisa. All of the hard work is Scott's. My
> changes to Scotts patch are=20
>  - change option to --format from --output
>  - make a couple of calls to function points conditional on the=20
>    function pointers being non-null
>  - updated the built-in documentation and the man page
>=20
> I also changed the copyright of json.c to Scott. Hope that's OK with
> Scott.

Well that's embarrassing. I just went through the effort of reviewing
the old patch and basically re-constructing that same list of tasks,
(only to find out that this updated patch was already sitting in my
queue, but later).

Anyway, very well done! I've applied this now with one change:

I'm now printing "thread" instead of "id" as the JSON name for the
field with the thread id in it.

I also added a mention to the TODO file that we should fix --format=3Djson
to not imply --entire-thread.

Thanks again, David and Scott (and we hope that all the backpacking goes
well, Scott!).

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLhEDv6JDdNq8qSWgRAr/XAJ90FVLYQGjaXoGmLPTdmHDvjSz0qgCeJiHK
buGDFeQEnn903cEjgVVOSeU=
=6RKI
-----END PGP SIGNATURE-----
--=-=-=--