Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6074E429E54 for ; Mon, 23 Jan 2012 10:01:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BJ7s8VdIpijq for ; Mon, 23 Jan 2012 10:01:39 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9829D429E21 for ; Mon, 23 Jan 2012 10:01:39 -0800 (PST) Received: by wibhi8 with SMTP id hi8so868826wib.26 for ; Mon, 23 Jan 2012 10:01:38 -0800 (PST) Received: by 10.180.77.228 with SMTP id v4mr15126731wiw.8.1327341321168; Mon, 23 Jan 2012 09:55:21 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id dr5sm43513222wib.0.2012.01.23.09.55.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Jan 2012 09:55:20 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id EE994A0950; Mon, 23 Jan 2012 17:55:17 +0000 (GMT) To: Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end In-Reply-To: <87d3aa1fot.fsf@servo.finestructure.net> References: <87pqea24z0.fsf@servo.finestructure.net> <1327307665-23387-1-git-send-email-jrollins@finestructure.net> <1327307665-23387-2-git-send-email-jrollins@finestructure.net> <1327307665-23387-3-git-send-email-jrollins@finestructure.net> <1327307665-23387-4-git-send-email-jrollins@finestructure.net> <87d3aa1fot.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+77~ge190cb9 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Mon, 23 Jan 2012 17:55:14 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Gm-Message-State: ALoCoQk1ML1gnr2Nu6WSP5LkSAPkFMTvRKjJrpT0d7MeXAhzARIPkKVOT7n19j/ccrz9EcYTwJVD X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 18:01:41 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 23 Jan 2012 09:39:30 -0800, Jameson Graef Rollins wrote: > On Mon, 23 Jan 2012 11:02:04 +0000, David Edmondson wrote: > > On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins wrote: > > > -(defun notmuch-show-next-open-message () > > > +(defun notmuch-show-next-open-message (&optional pop-at-end) > > > "Show the next message." > > > - (interactive) > > > - (let (r) > > > + (interactive "P") > > > + (let ((parent-buffer notmuch-show-parent-buffer) > > > + (r)) > >=20 > > Extra brackets around 'r' are unnecessary. Otherwise, +1. >=20 > This seems minor enough that I'm not going to resend, but noted for next > time. Thanks. On that basis, I hope no-one will complain if I fix them as a 'drive by' during another change... --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8dnwIACgkQaezQq/BJZRah/ACfVH+AJrKCGrjurcG8wIkTFMiX X94An01zh16X/VmggIzQHJdI+cr5AjC+ =NYan -----END PGP SIGNATURE----- --=-=-=--