Date: Mon, 19 Nov 2012 23:34:35 +1100
Message-ID: <20121119233435.GD2063@hili.localdomain>
From: Peter Wang <novalazy@gmail.com>
To: Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH 01/18] cli: add stub for insert command
In-Reply-To: <87fw46q0f7.fsf@qmul.ac.uk>
References: <1343223767-9812-1-git-send-email-novalazy@gmail.com>
	<87fw46q0f7.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Cc: notmuch@notmuchmail.org
Precedence: list

On Sun, 18 Nov 2012 17:35:23 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> 
> Hi
> 
> I have now been through essentially the whole series (except the tests)
> and broadly like it. Just to summarise my concerns from the individual
> replies here:

Thanks for the review.

> 
> What should insert do when interrupted and is it safe? I am not
> knowledgeable enough to be confident about that.

Do you mean cleaning up stray files?  Otherwise I think we just return
an error code, and then it's the caller's responsibility.

> 
> I think some of the talloc allocations need their return values
> checked. I am more worried about this here then in most of the rest of
> notmuch as we are writing to the database (and even to the mailstore
> itself).

Will do.

Peter