Date: Tue, 30 Oct 2012 23:17:25 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH v6 0/9] notmuch search date:since..until query support
Message-ID: <20121031031725.GL15377@mit.edu>
References: <cover.1351626272.git.jani@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1351626272.git.jani@nikula.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

LGTM.

Quoth Jani Nikula on Oct 30 at 10:32 pm:
> Hi all, v6 of [1] with plenty of small changes addressing Austin's
> review [2], [3], [4], and [5]. See my replies to Austin for what I've
> agreed to change, and what I've chosen to ignore and why.
> 
> The single biggest change is the requirement to have some delimiter(s)
> between keywords, which allowed simplification of keyword
> matching. Consequently match_keyword() and parse_keyword() functions in
> patch 2/9 have changed considerably.
> 
> There are a few ways to examine the changes since v5. My public repo at
> [6] has branches topic-parse-time-string-v5 (rebased to master) and
> topic-parse-time-string-v6, and [7] should provide a fancy colorful diff
> between the two. The same but less fancy diff is also at the end of this
> cover letter.
> 
> Change by change commits to the parser and test tool can also be found
> at [8]. The source files there are copied verbatim to patches 2/9 and
> 3/9.