Return-Path: <alex.boterolowry@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5E2AC431FBC
	for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 16:23:55 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ORtmZOcBYcSH for <notmuch@notmuchmail.org>;
	Tue, 17 Nov 2009 16:23:54 -0800 (PST)
Received: from mail-pw0-f51.google.com (mail-pw0-f51.google.com
	[209.85.160.51])
	by olra.theworths.org (Postfix) with ESMTP id 53BC2431FAE
	for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 16:23:54 -0800 (PST)
Received: by pwj10 with SMTP id 10so330396pwj.30
	for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 16:23:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:date:message-id:subject
	:from:to:content-type;
	bh=y05RtVbdTG7OYYRov2eQDLEBYICZsfRA3FRPP9nrMMQ=;
	b=AkNoq9jCKNbJaqh+bELYXMD1a1lsj4PTCJKOhL1EiNKvEvJrwRrNn55CKMUBHOfQ75
	CvJVgWygDHA2AYMtFIik0Axn3Svztf71+Ls9jiQymS9zP9IcLGCsm+SUR9dun74iWxvf
	QNU1N0xXlnUqADRq/hoVrui4VbBf1sjA5EGBE=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:date:message-id:subject:from:to:content-type;
	b=IXTiRksVsYYe71DPwZoAj1ou5XZOWuX1cGCf/CD8lyEf1V6bVDsO0v2efuJizBuzgs
	gZoU02whndlOIl1kwkgoCp+poe7xw7onwPeySJ2DY/QMsXQhwsnYTaYOKrANVBm3x3Ca
	75GT4xQKVIUUhLtlD97OAGfOuC+WxuIfabeYQ=
MIME-Version: 1.0
Received: by 10.114.186.37 with SMTP id j37mr5424456waf.36.1258503833548; Tue,
 	17 Nov 2009 16:23:53 -0800 (PST)
Date: Tue, 17 Nov 2009 16:23:53 -0800
Message-ID: <cf0c4d610911171623q3e27a0adx802e47039b57604b@mail.gmail.com>
From: Alex Botero-Lowry <alex.boterolowry@gmail.com>
To: notmuch@notmuchmail.org
Content-Type: multipart/mixed; boundary=0016e64ca4d8f27a4804789a4139
Subject: [notmuch] [PATCH] Error out if no query is supplied to search
	instead of going into an infinite loop
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2009 00:23:55 -0000

--0016e64ca4d8f27a4804789a4139
Content-Type: multipart/alternative; boundary=0016e64ca4d8f27a3604789a4137

--0016e64ca4d8f27a3604789a4137
Content-Type: text/plain; charset=ISO-8859-1

In this case error out when no query is supplied. There seems to be an
infinite-loop casued by i think notmuch_query_search_threads having
an exception:

A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>

I'll look into that bug specifically a bit later.

It might be better to do a usage instead of just throwing an error here?

alex

--0016e64ca4d8f27a3604789a4137
Content-Type: text/html; charset=ISO-8859-1

In this case error out when no query is supplied. There seems to be an infinite-loop casued by i think notmuch_query_search_threads having<br>an exception:<br><br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>
A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>
A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>
A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>
A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>
A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br><br>I&#39;ll look into that bug specifically a bit later.<br>
<br>It might be better to do a usage instead of just throwing an error here?<br><br>alex<br>

--0016e64ca4d8f27a3604789a4137--

--0016e64ca4d8f27a4804789a4139
Content-Type: application/octet-stream; 
	name="0001-Error-out-if-no-query-is-supplied-to-search-instead-.patch"
Content-Disposition: attachment; 
	filename="0001-Error-out-if-no-query-is-supplied-to-search-instead-.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g25cms190

RnJvbSAzZjk0MzFmNzRhNWZmNjZjODRjODY5YTNlMjZjMmJhZDQyYmVkMWIxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgQm90ZXJvLUxvd3J5IDxhbGV4LmJvdGVyb2xv
d3J5QGdtYWlsLmNvbT4KRGF0ZTogVHVlLCAxNyBOb3YgMjAwOSAxNjoyMDoyOCAtMDgwMApTdWJq
ZWN0OiBbUEFUQ0hdIEVycm9yIG91dCBpZiBubyBxdWVyeSBpcyBzdXBwbGllZCB0byBzZWFyY2gg
aW5zdGVhZCBvZiBnb2luZyBpbnRvIGFuIGluZmluaXRlIGxvb3AKCi0tLQogbm90bXVjaC1zZWFy
Y2guYyB8ICAgIDUgKysrKysKIDEgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAwIGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL25vdG11Y2gtc2VhcmNoLmMgYi9ub3RtdWNoLXNlYXJj
aC5jCmluZGV4IDhkYjA5YzcuLmQ5NGZjY2QgMTAwNjQ0Ci0tLSBhL25vdG11Y2gtc2VhcmNoLmMK
KysrIGIvbm90bXVjaC1zZWFyY2guYwpAQCAtNjYsNiArNjYsMTEgQEAgbm90bXVjaF9zZWFyY2hf
Y29tbWFuZCAodm9pZCAqY3R4LCBpbnQgYXJnYywgY2hhciAqYXJndltdKQogICAgIGFyZ2MgLT0g
aTsKICAgICBhcmd2ICs9IGk7CiAKKyAgICBpZiAoYXJnYyA9PSAwKSB7CisgICAgICAgIGZwcmlu
dGYgKHN0ZGVyciwgIk5vIHF1ZXJ5IHByb3ZpZGVkXG4iKTsKKyAgICAgICAgcmV0dXJuIDE7Cisg
ICAgfQorCiAgICAgY29uZmlnID0gbm90bXVjaF9jb25maWdfb3BlbiAoY3R4LCBOVUxMLCBOVUxM
KTsKICAgICBpZiAoY29uZmlnID09IE5VTEwpCiAJcmV0dXJuIDE7Ci0tIAoxLjYuNS4yCgo=
--0016e64ca4d8f27a4804789a4139--