Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DC50F431FC4 for ; Sat, 5 May 2012 16:21:55 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RMDiRkoNc3lo for ; Sat, 5 May 2012 16:21:55 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 664B8431FAE for ; Sat, 5 May 2012 16:21:55 -0700 (PDT) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SQoIT-0002K1-VY; Sat, 05 May 2012 20:21:54 -0300 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1SQoIO-0002Qy-C8; Sat, 05 May 2012 20:21:48 -0300 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2 1/6] lib/cli: Make notmuch_database_open return a status code In-Reply-To: <1335803138-24024-2-git-send-email-amdragon@mit.edu> References: <1335651473-19652-1-git-send-email-amdragon@mit.edu> <1335803138-24024-1-git-send-email-amdragon@mit.edu> <1335803138-24024-2-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.12+176~g3a32aa6 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Sat, 05 May 2012 20:21:48 -0300 Message-ID: <87fwbeb4dv.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2012 23:21:56 -0000 Austin Clements writes: > It has been a long-standing issue that notmuch_database_open doesn't > return any indication of why it failed. This patch changes its > prototype to return a notmuch_status_t and set an out-argument to the > database itself, like other functions that return both a status and an > object. pushed. d