Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 23DCE431FBD for ; Sun, 20 Apr 2014 15:57:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CuNzpLvk7y4i for ; Sun, 20 Apr 2014 15:57:09 -0700 (PDT) Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D1131431FBC for ; Sun, 20 Apr 2014 15:57:08 -0700 (PDT) Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim 4.72) (envelope-from ) id 1Wc0fX-0007Hj-Gh; Sun, 20 Apr 2014 22:57:03 +0000 Received: (nullmailer pid 7508 invoked by uid 1000); Sun, 20 Apr 2014 22:56:54 -0000 From: David Bremner To: Tomi Ollila , "W. Trevor King" , notmuch@notmuchmail.org Subject: Re: [PATCH 0/7] doc: Python 3 compat, rst2man.py support, etc. In-Reply-To: References: User-Agent: Notmuch/0.17+202~gb65f328 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 21 Apr 2014 07:56:54 +0900 Message-ID: <87wqejtxs9.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2014 22:57:17 -0000 Tomi Ollila writes: > In this series IMO the patches 1-4: > > id:8d518408f2da8bc96ae3123f05791142da26b9bc.1396718720.git.wking@tremily.us > id:543aee63407956e60f85dc11a2d25855e98c10c3.1396718720.git.wking@tremily.us > id:5e4509ab08699afe2681110fb35075e1d0bbdc7e.1396718720.git.wking@tremily.us > id:c5ec510ac25c867ad600c475a0070a003440a4b8.1396718720.git.wking@tremily.us > > could go in as those are. 5: > > id:adce76bb9a0ca728d856da4ecaf6b282e22e7440.1396718720.git.wking@tremily.us > > if, for consistency reason (we don't use absolute paths with other commands > either), rst2man/rst2man.py is used as is (and commit message adjusted > accordingly). I've queued 1-4 for merging. Any patches that might break the build (e.g. 5 and 6 in this series) have to go in pretty quick if they are to be in 0.18; patch 7 we can sort out during the freeze. I'm not sure I completely understand the state of the discussion around patch 5. Personally I don't like either undefined or empty RST2MAN as a boolean a priori. I'd rather keep HAVE_RST2MAN for consistency. d