Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 20AD0431FAF
	for <notmuch@notmuchmail.org>; Sat, 30 Nov 2013 05:50:57 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ig29Or5JjfdW for <notmuch@notmuchmail.org>;
	Sat, 30 Nov 2013 05:50:47 -0800 (PST)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 97125431FAE
	for <notmuch@notmuchmail.org>; Sat, 30 Nov 2013 05:50:47 -0800 (PST)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1VmkwU-0003g8-D8; Sat, 30 Nov 2013 09:50:42 -0400
Received: (nullmailer pid 17978 invoked by uid 1000); Sat, 30 Nov 2013
	13:50:38 -0000
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] emacs: Makefile.local: HAVE_EMACS usage fixes
In-Reply-To: <1377630047-27756-1-git-send-email-tomi.ollila@iki.fi>
References: <1377630047-27756-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.17~rc2 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 30 Nov 2013 09:50:38 -0400
Message-ID: <87ob523snl.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Nov 2013 13:50:57 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

>  
>  ifeq ($(WITH_EMACS),1)
>  ifeq ($(HAVE_EMACS),1)
>  all: $(emacs_bytecode)
> +install-emacs: $(emacs_bytecode)
>  endif
>  

It's a bit confusing that we have both HAVE_EMACS and WITH_EMACS. Should
this be documented somewhere? Otherwise the patch seems sensible.

See also the discussion at id:528B455A.70200@iki.fi.

d