Return-Path: <james@jameswestby.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 3BF26431FC0
	for <notmuch@notmuchmail.org>; Fri, 18 Dec 2009 16:08:32 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id vKs6VCMUS4HD for <notmuch@notmuchmail.org>;
	Fri, 18 Dec 2009 16:08:31 -0800 (PST)
Received: from jameswestby.net (jameswestby.net [89.145.97.141])
	by olra.theworths.org (Postfix) with ESMTP id 8000A431FBF
	for <notmuch@notmuchmail.org>; Fri, 18 Dec 2009 16:08:31 -0800 (PST)
Received: from cpc4-aztw22-2-0-cust59.aztw.cable.virginmedia.com
	([94.169.116.60] helo=flash)
	by jameswestby.net with esmtpa (Exim 4.69)
	(envelope-from <james@jameswestby.net>)
	id 1NLms1-0006By-Qg; Sat, 19 Dec 2009 00:08:29 +0000
Received: by flash (Postfix, from userid 1000)
	id 3A9CF6E546A; Sat, 19 Dec 2009 00:08:24 +0000 (GMT)
From: James Westby <jw+debian@jameswestby.net>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
In-Reply-To: <871virzzjy.fsf@yoom.home.cworth.org>
References: <87my1grrdi.fsf@jameswestby.net>
	<1261171263-29687-1-git-send-email-jw+debian@jameswestby.net>
	<871virzzjy.fsf@yoom.home.cworth.org>
Date: Sat, 19 Dec 2009 00:08:24 +0000
Message-ID: <87hbrnsu4n.fsf@jameswestby.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [notmuch] [PATCH] Store the size of the file for each message
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Dec 2009 00:08:32 -0000

On Fri, 18 Dec 2009 14:29:21 -0800, Carl Worth <cworth@cworth.org> wrote:
> On Fri, 18 Dec 2009 21:21:03 +0000, James Westby <jw+debian@jameswestby.net> wrote:
> Yes, a value makes sense here and should make the value easy to
> retrieve.

Excellent.

> I usually use a little tool I wrote called xapian-dump. It currently
> exists only in the git history of notmuch. Look at commit:
> 
> 	22691064666c03c5e76bc787395bfe586929f4cc
> 
> or so.

Thanks, I found delve, which at least showed that something was
being stored. It's in the xapian-tools package, and

   delve -V2 <database>

prints out the filesize value for each document.

It would be great if we could specify an alternative configuration
file for testing so that I can set up a small maildir and test
against that.

> If the file size is just an integer, then you shouldn't need a custom
> ValueRangeProcessor. One of the existing processors in Xapian should
> work fine.

Correct, I hadn't read the documentation closely enough. After fixing
that and doing some testing I have this working now. Patch incoming.

Thanks,

James