Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D142B431FAF for ; Sun, 25 Mar 2012 06:33:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Iu9L3a+Aijc for ; Sun, 25 Mar 2012 06:33:50 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4BBBD431FAE for ; Sun, 25 Mar 2012 06:33:50 -0700 (PDT) Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.166.230.117] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SBnZs-0007Nw-83; Sun, 25 Mar 2012 10:33:48 -0300 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1SBnZm-00075i-Uf; Sun, 25 Mar 2012 10:33:42 -0300 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function In-Reply-To: <5adca8d3701d9d01b8cb67e589ce8516d4df9832.1332604895.git.jani@nikula.org> References: <5adca8d3701d9d01b8cb67e589ce8516d4df9832.1332604895.git.jani@nikula.org> User-Agent: Notmuch/0.12 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 25 Mar 2012 10:33:42 -0300 Message-ID: <87bonkztxl.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2012 13:33:53 -0000 On Sat, 24 Mar 2012 18:14:37 +0200, Jani Nikula wrote: > Refactor to make tagging code easier to reuse in the future. No > functional changes. The second two look OK as well. It isn't obvious to me that in the long term we want an API using "file_tags" to pass in a string. It reminds me of the term "stringly typed". Of course, I see why it is this way in an intial refactor, but maybe something to think about before we start propagating such an API. d