From: David Bremner <david@tethera.net>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] Make parsing of References and In-Reply-To header
	less	error prone
In-Reply-To: <1401113157-32454-3-git-send-email-sojkam1@fel.cvut.cz>
References: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz>
	<1401113157-32454-3-git-send-email-sojkam1@fel.cvut.cz>
User-Agent: Notmuch/0.18.1+29~gb5327d4 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 13 Jul 2014 11:54:48 -0300
Message-ID: <8761j1fgw7.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Michal Sojka <sojkam1@fel.cvut.cz> writes:

> According to RFC2822 References and In-Reply-To headers are supposed
> to contain one or more Message-IDs, however older RFC822 allowed
> almost any content. When both References and In-Reply-To headers ends
> with something else that a Message-ID (see e.g. [1]), the thread
> structure presented by notmuch is incorrect. The reason is that
> notmuch treats this case as if the email contained no "replyto"
> information (see _notmuch_database_link_message_to_parents).
>
> This patch changes the parse_references() function to return the last
> valid Message-ID encountered rather than NULL resulting from the last
> hunk of text not being the Message-ID.

This series looks OK to me.  It does touch something pretty fundamental,
so I'd appreciate a second set of eyes on it.

d