Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 52074431FBC for ; Tue, 26 Jan 2010 11:17:51 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -3.559 X-Spam-Level: X-Spam-Status: No, score=-3.559 tagged_above=-999 required=5 tests=[AWL=0.626, BAYES_40=-0.185, RCVD_IN_DNSWL_MED=-4] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1tndAgqwZzm6 for ; Tue, 26 Jan 2010 11:17:50 -0800 (PST) Received: from brinza.cc.columbia.edu (brinza.cc.columbia.edu [128.59.29.8]) by olra.theworths.org (Postfix) with ESMTP id A73C3431FAE for ; Tue, 26 Jan 2010 11:17:50 -0800 (PST) Received: from servo.finestructure.net (cpe-72-227-128-66.nyc.res.rr.com [72.227.128.66]) (user=jgr2110 author=jrollins@finestructure.net mech=PLAIN bits=0) by brinza.cc.columbia.edu (8.14.3/8.14.3) with ESMTP id o0QJHnef012617 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 26 Jan 2010 14:17:50 -0500 (EST) Received: from jrollins by servo.finestructure.net with local (Exim 4.71) (envelope-from ) id 1NZqv7-0000Ly-Fm for notmuch@notmuchmail.org; Tue, 26 Jan 2010 14:17:49 -0500 From: Jameson Rollins To: Notmuch Mail list Date: Tue, 26 Jan 2010 13:49:46 -0500 Message-ID: <87r5pcad5v.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-No-Spam-Score: Local X-Scanned-By: MIMEDefang 2.68 on 128.59.29.8 Subject: [notmuch] [PATCH] Remove bcc header from notmuch reply. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 19:17:51 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable Notmuch reply should not be Bcc'ing the sender by default. This is not the appropriate way to save copies of sent mail (which should probably be handled by an Fcc header) and it doesn't give the user the option to not be bcc'd. This is really something that should be handled by the reader UI. For instance, emacs message-mode can easily be configured to add Bcc's if the user wishes. =2D-- notmuch-reply.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 0cda72d..de05aaf 100644 =2D-- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -30,8 +30,7 @@ static const struct { } reply_to_map[] =3D { { "reply-to", "from", GMIME_RECIPIENT_TYPE_TO }, { "to", NULL, GMIME_RECIPIENT_TYPE_TO }, =2D { "cc", NULL, GMIME_RECIPIENT_TYPE_CC }, =2D { "bcc", NULL, GMIME_RECIPIENT_TYPE_BCC } + { "cc", NULL, GMIME_RECIPIENT_TYPE_CC } }; =20 static void @@ -254,9 +253,6 @@ notmuch_reply_format_default(void *ctx, notmuch_config_= t *config, notmuch_query_ g_mime_object_set_header (GMIME_OBJECT (reply), "From", from_addr); =20 =2D g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc", =2D notmuch_config_get_user_primary_email (config)); =2D in_reply_to =3D talloc_asprintf (ctx, "<%s>", notmuch_message_get_message_id (message)); =20 @@ -346,9 +342,6 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_co= nfig_t *config, notmuch_q recipients); } =20 =2D g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc", =2D notmuch_config_get_user_primary_email (config)); =2D reply_headers =3D g_mime_object_to_string (GMIME_OBJECT (reply)); printf ("%s", reply_headers); free (reply_headers); =2D-=20 1.6.5 --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBCAAGBQJLXz/cAAoJEO00zqvie6q89XkP/1Emg/RY8vJQCAMj4FfKemip C6NXtOvhQOEJzCtq8nDfhsIRo2NQZk22AirzQGcqhZj6dHJwElbKcds93Nvkyu03 8e+/uvHH2TrQXHGhVtwJbCTbkIwYskt3sL1PZYEnKoes37QLZkdLPQVIvcSYr/Xj Rei/7NsjXOK8hASjo/MH2jw21x708E7wyIpk7bLNROyKBGW5ZsHxeM51gluZYVoq 3E34lwC7jAFec05Mj5TfEz52O6P/m4dyWB1wqki1Z3GKMBGury3xl6sDrx1MHT1w mGOrA5HcSU9Zz+GqUFDqvj3MPR4j+fb0XmLtuwe5wBr9jDnen0+UloOYwSdLiX0S yScLLxHs1l+h1tQfQXY/UhNBDKlbxEgZw94N6LdyDNv+UCRrDkCgZlscth8VK4zs C4zXRywFvmFe6zhJiM9PUxu0nkyYeWWJ5H6ZFAF8yhsftIYFfjCpTY05jJIaRwtR gXGrI+sBEWEYa5vXPFK6X9mzuP+6EtuEKr6QJug2MpEy9aGcvO7cgZTjhOR8Kuo3 nlh3XSxT4uRoAYWZkDw67RfLHECSlpGjXeOsUUqqbRlUmm4ezoHmS3jiqBlE8NPE /t7KIcAG0kx2hqq2eOaKOpCVwwE+jgH5zZPLMheEPzK/PiCK7FukmO9/7Ghky9GF yHGNfCXb8t1gk3Hz25vX =FH8l -----END PGP SIGNATURE----- --=-=-=--