Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id B8031431FBD
	for <notmuch@notmuchmail.org>; Sun,  2 Feb 2014 12:59:42 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id WtEZcSB6o1jg for <notmuch@notmuchmail.org>;
	Sun,  2 Feb 2014 12:59:38 -0800 (PST)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 077C7431FBC
	for <notmuch@notmuchmail.org>; Sun,  2 Feb 2014 12:59:38 -0800 (PST)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1WA48b-0003zD-59; Sun, 02 Feb 2014 16:59:33 -0400
Received: (nullmailer pid 7988 invoked by uid 1000); Sun, 02 Feb 2014
	20:59:27 -0000
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: only install bash completion if supported
In-Reply-To: <877g9dqup5.fsf@qmul.ac.uk>
References: <1391359677-12497-1-git-send-email-jani@nikula.org>
	<877g9dqup5.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.17~rc3 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 02 Feb 2014 16:59:27 -0400
Message-ID: <878utt1b9s.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Feb 2014 20:59:42 -0000

Mark Walters <markwalters1009@gmail.com> writes:

> This LGTM (untested)

I did test it, at least completely removing bash completion works as
expected.  

Unfortunately --with-bash-completion does not override this test because
the order things are processed. Do you think this is a bug?  I wondered
if users that "know what they are doing" (TM) might want to force
installation even though the pkg-config test fails.

d