Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 16290431FAF for ; Sun, 15 Apr 2012 10:33:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9zyYtblCI+-0 for ; Sun, 15 Apr 2012 10:33:26 -0700 (PDT) Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) by olra.theworths.org (Postfix) with ESMTP id 571AC431FAE for ; Sun, 15 Apr 2012 10:33:26 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id 2C42E68055; Sun, 15 Apr 2012 20:33:22 +0300 (EEST) From: Tomi Ollila To: Mark Walters , David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the end of the buffer. In-Reply-To: <87lilw6hnw.fsf@qmul.ac.uk> References: <1327996914-9644-1-git-send-email-dme@dme.org> <1327996914-9644-3-git-send-email-dme@dme.org> <87lilw6hnw.fsf@qmul.ac.uk> User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Apr 2012 17:33:27 -0000 On Sun, Apr 15 2012, Mark Walters wrote: > On Tue, 31 Jan 2012, David Edmondson wrote: >> When using the spacebar to scroll through a thread, hitting 'space' >> when the bottom of the last message is visible should take the cursor >> to the end of the buffer rather than immediately archiving the thread >> and moving to the next thread. > > Hi > > This patch looks good to me; (but if people prefer the current behaviour then > can we mark this notmuch::wontfix so it leaves the review queue) I would definitely like to see this patch applied. Less surprising as there is no indication we have reached the bottom of the buffer. > Best wishes > > Mark Tomi > >> --- >> emacs/notmuch-show.el | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el >> index ec72ff8..3f54de0 100644 >> --- a/emacs/notmuch-show.el >> +++ b/emacs/notmuch-show.el >> @@ -1319,6 +1319,11 @@ current window), advance to the next open message." >> ;; This is not the last message - move to the next visible one. >> (notmuch-show-next-open-message)) >> >> + ((not (= (point) (point-max))) >> + ;; This is the last message, but the cursor is not at the end of >> + ;; the buffer. Move it there. >> + (goto-char (point-max))) >> + >> (t >> ;; This is the last message - change the return value >> (setq ret t))) >> -- >> 1.7.8.3 >> >> _______________________________________________ >> notmuch mailing list >> notmuch@notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch