Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3029A431FD0 for ; Mon, 23 May 2011 14:38:15 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XXyaGKQ8EIDT for ; Mon, 23 May 2011 14:38:14 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 5250A431FB6 for ; Mon, 23 May 2011 14:38:14 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 84D0F29A4F5; Mon, 23 May 2011 14:38:12 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 4334C254183; Mon, 23 May 2011 14:38:12 -0700 (PDT) From: Carl Worth To: Matthias Guedemann , Dirk Hohndel , "notmuch\@notmuchmail.org" Subject: Re: problems with multipart/mixed In-Reply-To: <877h9hmt8k.fsf@pc44es141.cs.uni-magdeburg.de> References: <878vu0ftni.fsf@pc44es141.cs.uni-magdeburg.de> <877h9hmt8k.fsf@pc44es141.cs.uni-magdeburg.de> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Mon, 23 May 2011 14:38:05 -0700 Message-ID: <87vcx1m72a.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2011 21:38:15 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 23 May 2011 15:39:07 +0200, Matthias Guedemann wrote: >=20 > > If you did then I'm in the same boat. Notmuch/emacs used to display both >=20 > welcome to the boat! My fault. I'm sorry about this breakage. > Now a quick-and-dirty way around this: >=20 > reset to c51d5b3cdb5ca0816816e88ca6f7136a24e74eee >=20 > and apply this patch: .. > - *part_count =3D *part_count + 1; > - (*show_part) (part, part_count); > + //*part_count =3D *part_count + 1; > + //(*show_part) (part, part_count); Your patch here removes the change to the part numbering for "notmuch show". I've just pushed a change which instead adds this same part numbering to "notmuch part". Please try it out and let me know if you have any further trouble. Clearly, we've got a hole in our test suite since it didn't notice this problem at all. Meanwhile, Jameson has proposed (in IRC) a patch series to further rework the way that "notmuch part" works. That series also adds various tests for "notmuch part" (which will instead be called "notmuch show =2D-part") to the test suite. So hopefully we won't have this same regression appear in the future. Thanks, everyone for reporting this bug. =2DCarl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3a070ACgkQ6JDdNq8qSWi5igCdHoKI0lxDDDMudtP1BJXgRlZD YccAniUTulZR4Dg9a3EsUJRTvrM4JnEB =LJc2 -----END PGP SIGNATURE----- --=-=-=--