From: Austin Clements <amdragon@MIT.EDU>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [RFC PATCH] revert: Removed top level --stderr= option
In-Reply-To: <1370027431-16018-1-git-send-email-tomi.ollila@iki.fi>
References: <1370027431-16018-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.15.2+174~g8d6aa60 (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Thu, 13 Jun 2013 12:20:14 -0400
Message-ID: <87hah20ypt.fsf@awakening.csail.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: tomi.ollila@iki.fi
Precedence: list

LGTM.  While I thought --stderr was a fine solution originally, now that
we've stumbled across problems that make it difficult to use correctly
and robustly, I think Tomi's right that we should probably revert it.

On Fri, 31 May 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> While looked good on paper, its attempted use caused confusion, complexity,
> and potential for information leak when passed through wrapper scripts.
> For slimmer code and to lessen demand for maintenance/support the set of
> commits which added top level --stderr= option is now reverted.
> ---
>
> Change was easy, commit message hard. Opinions? Revert is easiest to do now.
> Also, if someone comes with a novel idea how to utilize --stderr option
> please tell it now -- I'd be most eager to hear it :D
>
>
> This change was done the following way:
>
> $ git checkout -b rvrt b9020448bd
> $ git reset --hard HEAD^^^^
> $ git reset b9020448bd
> $ git commit -a
> $ git diff HEAD~5..HEAD
>
> (last one to reveal HEAD~5 & HEAD have identical trees).
>
> Question why:
> id:20130521195549.6550.53636@thinkbox.jade-hamburg.de
>
> Good reason why not:
> id:1369934016-22308-1-git-send-email-amdragon@mit.edu