Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 284396DE1607 for ; Fri, 31 Jul 2015 22:50:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.15 X-Spam-Level: X-Spam-Status: No, score=0.15 tagged_above=-999 required=5 tests=[AWL=0.150] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e7hswqroZGvS for ; Fri, 31 Jul 2015 22:50:52 -0700 (PDT) Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) by arlo.cworth.org (Postfix) with ESMTPS id 181C76DE1384 for ; Fri, 31 Jul 2015 22:50:51 -0700 (PDT) Received: from remotemail by gitolite.debian.net with local (Exim 4.80) (envelope-from ) id 1ZLPff-00047A-QT; Sat, 01 Aug 2015 05:49:23 +0000 Received: (nullmailer pid 21893 invoked by uid 1000); Sat, 01 Aug 2015 05:49:09 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 3/4] emacs: tree: add sort argument to notmuch-tree In-Reply-To: <1435359035-6767-4-git-send-email-markwalters1009@gmail.com> References: <1435359035-6767-1-git-send-email-markwalters1009@gmail.com> <1435359035-6767-4-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sat, 01 Aug 2015 07:49:09 +0200 Message-ID: <87614zftii.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Aug 2015 05:50:54 -0000 Mark Walters writes: > + OPEN-TARGET: If TRUE open the target message in the message pane. > + OLDEST-FIRST: If TRUE display threads sorted oldest first" > + (interactive > + (list > + ;; Prompt for a query > + nil > + ;; use default search order > + nil nil nil nil (default-value 'notmuch-search-oldest-first))) This is probably just me being ignorant, but I had to check the docs for this usage of interactive. If you think it's tricky also, might be worth a brief comment. Otherwise the series looks ok to me.