Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B2135431FBD for ; Sat, 14 Jul 2012 12:06:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jzCJBYU8Kkns for ; Sat, 14 Jul 2012 12:06:25 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 5DAF7431FBC for ; Sat, 14 Jul 2012 12:06:25 -0700 (PDT) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id D19AC66E00D2; Sat, 14 Jul 2012 12:06:22 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (unknown [76.89.192.57]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 0150166E00A6; Sat, 14 Jul 2012 12:06:19 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 860B273E; Sat, 14 Jul 2012 12:06:19 -0700 (PDT) From: Jameson Graef Rollins To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2 0/7] emacs: JSON-based search cleanups In-Reply-To: <1342237406-32507-1-git-send-email-amdragon@mit.edu> References: <1342140319-19859-1-git-send-email-amdragon@mit.edu> <1342237406-32507-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.13.2+82~gd0a8b58 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Sat, 14 Jul 2012 12:06:17 -0700 Message-ID: <87ehoef9hy.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2012 19:06:27 -0000 --=-=-= On Fri, Jul 13 2012, Austin Clements wrote: > This version updates the docstrings for notmuch-search-update-result > and notmuch-search-show-result and fixes the scrolling artifact in > notmuch-search-update-result. I also updated the commit message of > patch 7 to mention that it changes the behavior of > notmuch-search-previous-thread. Hey, Austin. This is a really nice series. Very nice cleanup, with a lot of great side effects. It definitely looks good to me, although like Mark, I don't quite grok the defmacro in patch 4. But this is only my ignorance and not a comment on the patch at all. I've also tested and the series seems to work great. I want to try some multi-line search results now! jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJQAcMpAAoJEO00zqvie6q8aqsQAJaETMB3lW+CMhxue8LqyL1/ /xZfDgowesK1TPlMgxKEdefVZUtv3H1UEmiFTz/pUrKyjxjpgmPMaqeHXC8uxU8y hsCsPHxrkaugAS44LOmOpmX4lIE3j2QL9hdlD0cb7VL9FsgMAU0qJsPJBVi//XSM tGeuzitToPksr/StecNPUGSh2b1ngzxl9jv18hdYhYTr9DH8hGaKWF/okuBAhOMY eXCPS2ofKgSOUCNJjMyAU92FScO6LM+A3Xk+Exey+HI0M8kmqXzM83amT0iif6T6 e6XC5ded0JBTKNkwkYvi1TvRJKiarHHQqZHHZzjqtjA8/fXR5sBHZrGVtpw7I4Qv B4ir0mv4w4iqF/atJGwObcI7nYeCbpy/W9rqb0f57EgUIpM/YAkq1jyKJ6pqK5bc aoNAW3YpP2yGFZeKj4J322zp2k3WJevzoPQFolahKHxiZGK9jZam3gSv/OnDmzzJ plsuEMc7jdtNF6Nw3eoU3GCXCx92Zi1rt00n5ca7hdCUqPm3PGHVlfQsUQYY7NhO yKL6WJ9UDXktgtFecLHsLHF9agyX/a37Y1VxK/o3NYKADJ5y8ukcCt7kbshfBTCL QUA2X73mY+zuvshFMBE74InRfZfI6jQTqTvR2WiHOeYJAVb1VbD0G+psi0TR7dTm W/5Z3B3pJ14CXOUk4nDy =1GIV -----END PGP SIGNATURE----- --=-=-=--