Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2569A431FBF; Sun, 22 Nov 2009 18:39:09 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eGkLKnyVSDTU; Sun, 22 Nov 2009 18:38:40 -0800 (PST) Received: from cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 433C0431FAE; Sun, 22 Nov 2009 18:38:40 -0800 (PST) From: Carl Worth To: Jan Janak , notmuch@notmuchmail.org In-Reply-To: <1258893156-25849-1-git-send-email-jan@ryngle.com> References: <1258893156-25849-1-git-send-email-jan@ryngle.com> Date: Mon, 23 Nov 2009 03:38:25 +0100 Message-ID: <876392ge3i.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] [PATCH] notmuch-new: Eliminate gcc warning caused by ino_cmp. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2009 02:39:09 -0000 On Sun, 22 Nov 2009 13:32:36 +0100, Jan Janak wrote: > The function passed to scandir in the fourth argument takes two > const void* arguments. To eliminate the gcc warning about incompatible > types, we change ino_cmp to match this and then re-type the parameters > in the body of ino_cmp. Actually, on my system at least, (Linux with glibc 2.10.1), our current function matches the prototype. So applying your patch actually *introduces* a warning where there was no warning before. What a nuisance... Any ideas for a good fix, anyone? -Carl