From: Carl Worth <cworth@cworth.org>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
	Notmuch developer list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Rename already used counter var i
In-Reply-To: <1272373045-29268-1-git-send-email-Sebastian@SSpaeth.de>
References: <87tyqxmdw6.fsf@yoom.home.cworth.org>
	<1272373045-29268-1-git-send-email-Sebastian@SSpaeth.de>
User-Agent: Notmuch/0.2-251-g8514e59 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Tue, 27 Apr 2010 08:12:46 -0700
Message-ID: <87r5m1lyj5.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 27 Apr 2010 14:57:25 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de>=
 wrote:
> From: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> i is already used in a for loop at this point, so using i here again
> broke notmuch-reply (it would just hang). Use j instead of i here.

Thanks for the fix.

>  Aneesh noticed this bug and provided a fix for it. IMO it warrants a 0.3=
.1
>  release. notmuch-reply hanging indefinitely is not going to make grumpy
>  editors happy.


Definitely.

For a point release like 0.3.1 I'm going to insist on a test case that
demonstrates each regression being fixed. Does someone know what it
takes to make a mail trigger this bug?

>  Also despite a documentation blurb above the main snippet of
>  code, I find it pretty much black magic what is being done here. But the=
n=20
>  I don't really know C....

I find it pretty much black magic too. I rewrote one piece of
black-magic code late last night when we noticed it was causing crashes
and valgrind was complaining. I'll dive in and give this chunk of code
some similar treatment.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFL1v7u6JDdNq8qSWgRAgQGAJ9xJh55o3PALeJrCiUcsogvrZ6MiQCfcFbg
S99Z/jI645zQTcMmuM60yiE=
=LhWS
-----END PGP SIGNATURE-----
--=-=-=--