Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5E5FE431E64
	for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:38:53 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id RMU7P9D2eA9S for <notmuch@notmuchmail.org>;
	Mon, 30 Jan 2012 06:38:52 -0800 (PST)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id B88CA431FBC
	for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:38:52 -0800 (PST)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id A330068056; Mon, 30 Jan 2012 16:38:55 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] STYLE: Initial draft of coding style document
In-Reply-To: <1327708018-1107-1-git-send-email-david@tethera.net>
References: <1327708018-1107-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.11+129~g3b527ae (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Mon, 30 Jan 2012 16:38:55 +0200
Message-ID: <m2ehuhdzls.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Bremner <bremner@debian.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jan 2012 14:38:53 -0000

On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner <david@tethera.net> wrote:
> From: David Bremner <bremner@debian.org>

[ ... ]

> +
> +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8.
> +  Tabs should be only at the beginning of the line.

So, after initial indentation (with tabs) there should not be further
tabs? We'll be using the former instead of the latter in these 2 below?

/* excerpt from command-line-arguments.h -- indentation without tabs */

enum notmuch_opt_type {
    NOTMUCH_OPT_END = 0,
    NOTMUCH_OPT_BOOLEAN,        /* --verbose              */
    NOTMUCH_OPT_INT,            /* --frob=8               */
    NOTMUCH_OPT_KEYWORD,        /* --format=raw|json|text */
    NOTMUCH_OPT_STRING,         /* --file=/tmp/gnarf.txt  */
    NOTMUCH_OPT_POSITION        /* notmuch dump pos_arg   */
};

/* excerpt from command-line-arguments.h -- indentation with tabs */

enum notmuch_opt_type {
    NOTMUCH_OPT_END = 0,
    NOTMUCH_OPT_BOOLEAN,	/* --verbose              */
    NOTMUCH_OPT_INT,		/* --frob=8               */
    NOTMUCH_OPT_KEYWORD,	/* --format=raw|json|text */
    NOTMUCH_OPT_STRING,		/* --file=/tmp/gnarf.txt  */
    NOTMUCH_OPT_POSITION	/* notmuch dump pos_arg   */
};


[ ... ]


Tomi